From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] tests/kms_cursor_crc: HSW/BDW only have square cursors Date: Tue, 14 Oct 2014 22:32:22 +0300 Message-ID: <20141014193222.GD4284@intel.com> References: <1413306342-23660-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C2B46E0DA for ; Tue, 14 Oct 2014 12:33:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1413306342-23660-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Tue, Oct 14, 2014 at 02:05:42PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > = > When I look at BSpec, and at cursor_size_ok() (from the Kernel's > intel_display.c), I see that only 845g and i865g support non-square > displays, so SKIP the tests on HSW/BDW instead of failing them. > = > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D84268 > Cc: Ville Syrj=E4l=E4 > Signed-off-by: Paulo Zanoni http://lists.freedesktop.org/archives/intel-gfx/2014-September/052310.html Sadly I hit one small extra problem with the patches and didn't manage to send out revised versions before my new BSW arrived, at which point I had actual work to do again and couldn't play around with cursors :) Sometime soon I should hopefully have a few spare cycles to finish off that cursor stuff. > --- > tests/kms_cursor_crc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > = > diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c > index 92d1ce6..87b4f64 100644 > --- a/tests/kms_cursor_crc.c > +++ b/tests/kms_cursor_crc.c > @@ -371,10 +371,7 @@ static bool has_nonsquare_cursors(uint32_t devid) > * Test non-square cursors a bit on the platforms > * that support such things. > */ > - return devid =3D=3D PCI_CHIP_845_G || > - devid =3D=3D PCI_CHIP_I865_G || > - (IS_GEN7(devid) && !IS_VALLEYVIEW(devid)) || > - (IS_GEN8(devid) && !IS_CHERRYVIEW(devid)); > + return devid =3D=3D PCI_CHIP_845_G || devid =3D=3D PCI_CHIP_I865_G; > } > = > static void test_cursor_size(data_t *data) > -- = > 1.9.1 -- = Ville Syrj=E4l=E4 Intel OTC