From: Lee Jones <lee.jones@linaro.org>
To: Will Sheppard <wsheppard@embedded-bits.co.uk>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] mfd: arizona-spi: Add lines after declarations - checkpatch catch
Date: Wed, 15 Oct 2014 11:04:10 +0200 [thread overview]
Message-ID: <20141015090410.GA9900@lee--X1> (raw)
In-Reply-To: <1413362327-17378-1-git-send-email-wsheppard@embedded-bits.co.uk>
On Wed, 15 Oct 2014, Will Sheppard wrote:
> This was found whilst running checkpatch.pl on arizona-spi.
>
> WARNING: Missing a blank line after declarations
> + struct arizona *arizona = spi_get_drvdata(spi);
> + arizona_dev_exit(arizona);
>
> Signed-off-by: Will Sheppard <wsheppard@embedded-bits.co.uk>
> ---
> drivers/mfd/arizona-spi.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied for v3.19.
> diff --git a/drivers/mfd/arizona-spi.c b/drivers/mfd/arizona-spi.c
> index 5145d78..8ef58bc 100644
> --- a/drivers/mfd/arizona-spi.c
> +++ b/drivers/mfd/arizona-spi.c
> @@ -75,7 +75,9 @@ static int arizona_spi_probe(struct spi_device *spi)
> static int arizona_spi_remove(struct spi_device *spi)
> {
> struct arizona *arizona = spi_get_drvdata(spi);
> +
> arizona_dev_exit(arizona);
> +
> return 0;
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-10-15 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 8:38 [PATCH] mfd: arizona-spi: Add lines after declarations - checkpatch catch Will Sheppard
2014-10-15 9:04 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015090410.GA9900@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
--cc=wsheppard@embedded-bits.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.