From: Sergey Senozhatsky <sergey.senozhatsky at gmail.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH v3 04/15] clean up Makefile.am files
Date: Wed, 15 Oct 2014 22:03:00 +0900 [thread overview]
Message-ID: <20141015130300.GE1189@swordfish> (raw)
In-Reply-To: CAG27Bk0_nMryZ2CsF7d6q+y5v8guZwTH5dT1r4m_Gy4F3PX6Zw@mail.gmail.com
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
On (10/15/14 09:25), Sami Kerola wrote:
> >> ---
> >> Makefile.am | 14 +++-
> [snip]
> >> +powertop_SOURCES = \
> >> + css.h \
> >> + devlist.cpp \
> >> + devlist.h \
> >> + display.cpp \
> >> + display.h \
> >> + lib.cpp \
> >> + lib.h \
> >> + main.cpp \
> >> + powertop.css \
> >> + \
> >
> > Why the white line here?
>
> To separate src/*.(cpp|h) file from files in sub-directory targets the
> way one very clearly see the difference. Sorting all the targets in
> simple alphabetical order would make the none-sub-directory objects to
> be here and there in middle of listing, so separating the lists seemed
> like clarity enhancement to me. If the empty line really annoys send a
> patch to remove it, I don't have too strong opinions either in favor
> or against it.
>
:-)
guys, this is Makefile.am
nobody goes there.
-ss
next reply other threads:[~2014-10-15 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 13:03 Sergey Senozhatsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-15 8:25 [Powertop] [PATCH v3 04/15] clean up Makefile.am files Sami Kerola
2014-10-14 23:34 Joe Konno
2014-09-07 21:27 Sami Kerola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015130300.GE1189@swordfish \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.