From: Felipe Balbi <balbi@ti.com>
To: Vivek Gautam <gautam.vivek@samsung.com>
Cc: Felipe Balbi <balbi@ti.com>,
Anton Tikhomirov <av.tikhomirov@samsung.com>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>, robh+dt <robh+dt@kernel.org>,
kishon <kishon@ti.com>
Subject: Re: [PATCH v2 1/4] dwc3: exynos: Add support for SCLK present on Exynos7
Date: Wed, 15 Oct 2014 09:50:31 -0500 [thread overview]
Message-ID: <20141015145031.GA11511@saruman> (raw)
In-Reply-To: <CAFp+6iEKkHxJNzkf+LOWJHtOhtZMe7HG_Vg97_NLfhJw11SQpA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]
Hi,
On Tue, Oct 14, 2014 at 10:25:00AM +0530, Vivek Gautam wrote:
> Hi Felipe,
>
>
> On Tue, Oct 14, 2014 at 4:14 AM, Felipe Balbi <balbi@ti.com> wrote:
> > Hi,
> >
> > On Mon, Oct 13, 2014 at 01:54:59PM +0900, Anton Tikhomirov wrote:
> >> Hi Vivek,
> >>
> >> > Exynos7 also has a separate special gate clock going to the IP
> >> > apart from the usual AHB clock. So add support for the same.
> >>
> >> As we discussed before, Exynos7 SoCs have 7 clocks to be controlled
> >> by the driver. Adding only sclk is not enough.
> >>
> >> >
> >> > Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> >> > ---
> >> > drivers/usb/dwc3/dwc3-exynos.c | 16 ++++++++++++++++
> >> > 1 file changed, 16 insertions(+)
> >> >
> >> > diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-
> >> > exynos.c
> >> > index 3951a65..7dc6a98 100644
> >> > --- a/drivers/usb/dwc3/dwc3-exynos.c
> >> > +++ b/drivers/usb/dwc3/dwc3-exynos.c
> >> > @@ -35,6 +35,7 @@ struct dwc3_exynos {
> >> > struct device *dev;
> >> >
> >> > struct clk *clk;
> >>
> >> The clock "clk" in Exynos5 just gated all that above 7 clocks, which
> >> we should control separately now in Exynos7.
> >>
> >
> > should I drop this patch for now ?
>
> Yes, better to hold this for some time till we get more clarity
> from our h/w team.
now dropped. Please a new one if needed.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-15 14:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 10:19 [PATCH v2 0/4] usb: dwc3/phy-exynos5-usbdrd: Extend support to Exynos7 Vivek Gautam
2014-10-07 10:19 ` Vivek Gautam
2014-10-07 10:19 ` [PATCH v2 1/4] dwc3: exynos: Add support for SCLK present on Exynos7 Vivek Gautam
2014-10-07 14:11 ` Felipe Balbi
2014-10-07 14:11 ` Felipe Balbi
2014-10-08 3:01 ` Vivek Gautam
2014-10-13 4:54 ` Anton Tikhomirov
2014-10-13 22:44 ` Felipe Balbi
2014-10-13 22:44 ` Felipe Balbi
2014-10-14 4:55 ` Vivek Gautam
2014-10-15 14:50 ` Felipe Balbi [this message]
[not found] ` <00f101cfe6a1$d772c5a0$865850e0$%tikhomirov-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-10-13 22:51 ` Tomasz Figa
2014-10-13 22:51 ` Tomasz Figa
2014-10-14 1:26 ` Anton Tikhomirov
2014-10-14 4:53 ` Vivek Gautam
[not found] ` <1412677176-3850-1-git-send-email-gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-10-07 10:19 ` [PATCH v2 2/4] phy: exynos5-usbdrd: Add pipe-clk and utmi-clk support Vivek Gautam
2014-10-07 10:19 ` Vivek Gautam
2014-10-13 5:02 ` Anton Tikhomirov
2014-10-22 11:53 ` Kishon Vijay Abraham I
2014-10-22 11:53 ` Kishon Vijay Abraham I
2014-10-07 10:19 ` [PATCH v2 3/4] phy: exynos5-usbdrd: Add facility for VBUS-BOOST-5V supply Vivek Gautam
2014-10-13 5:06 ` Anton Tikhomirov
2014-10-13 5:11 ` Vivek Gautam
2014-10-07 10:19 ` [PATCH v2 4/4] phy: exynos7-usbdrd: Update dependency for ARCH_EXYNOS Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015145031.GA11511@saruman \
--to=balbi@ti.com \
--cc=av.tikhomirov@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gautam.vivek@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=kgene.kim@samsung.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.