From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751962AbaJOT4L (ORCPT ); Wed, 15 Oct 2014 15:56:11 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:16872 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbaJOT4I (ORCPT ); Wed, 15 Oct 2014 15:56:08 -0400 Date: Wed, 15 Oct 2014 22:55:49 +0300 From: Dan Carpenter To: Jeff Kirsher Cc: gregkh@linuxfoundation.org, Fabio Estevam , linux-kernel@vger.kernel.org, mail@beyermatthias.de, devel@driverdev.osuosl.org, Joe Perches Subject: Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings Message-ID: <20141015195549.GR26918@mwanda> References: <1413399701-4321-1-git-send-email-jeffrey.t.kirsher@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1413399701-4321-1-git-send-email-jeffrey.t.kirsher@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 15, 2014 at 12:01:41PM -0700, Jeff Kirsher wrote: > From: Fabio Estevam > > The Beceem WIMAX was generating compile warnings on 64bit machines, > which were: > > drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’: > drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > (struct bcm_connect_mgr_params *) ntohl( > ^ > drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > (struct bcm_connect_mgr_params *) ntohl( > ^ > drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > (struct bcm_connect_mgr_params *) ntohl( > > This resolves the issue by preventing the driver to compile if CONFIG_64BIT > is enabled, since the driver is known to be broken for 64 bit arch's. > Oops. Someone turned a Joe patch into a real patch. Please enable COMPILE_TEST for this. regards, dan carpenter