From: Alexander Aring <alex.aring@gmail.com>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Jukka Rissanen <jukka.rissanen@linux.intel.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Incorrect locking when sending data in softirq
Date: Wed, 15 Oct 2014 23:53:27 +0200 [thread overview]
Message-ID: <20141015215324.GB17138@omega> (raw)
In-Reply-To: <543EDD20.8050508@hurleysoftware.com>
Hi Peter,
On Wed, Oct 15, 2014 at 04:46:24PM -0400, Peter Hurley wrote:
...
>
> That's happening because 6lowpan.c:send_mcast_pkt() is disabling
> interrupts with the read_lock_irqsave() before calling send_pkt().
>
> It's unclear browsing through the lowpan driver why the
> irqflags save/restore read_lock flavors are being used; is there a
> place where the bluetooth core is calling the driver in atomic
> context (ie., where interrupts are disabled)?
>
In my opinion bt_xmit is called in atomic context. Make the stacktrace
sense now?
It's the callback 'ndo_start_xmit' of 'struct net_device_ops' [0].
- Alex
[0] http://lxr.free-electrons.com/source/include/linux/netdevice.h#L1001
next prev parent reply other threads:[~2014-10-15 21:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 12:43 [PATCH] Bluetooth: Incorrect locking when sending data in softirq Jukka Rissanen
2014-10-15 13:18 ` Peter Hurley
2014-10-15 13:32 ` Jukka Rissanen
2014-10-15 20:46 ` Peter Hurley
2014-10-15 21:53 ` Alexander Aring [this message]
2014-10-15 21:58 ` Peter Hurley
2014-10-15 22:23 ` Alexander Aring
2014-10-16 1:20 ` Peter Hurley
2014-10-16 7:47 ` Jukka Rissanen
2014-10-15 13:36 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015215324.GB17138@omega \
--to=alex.aring@gmail.com \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.