From: Oleg Nesterov <oleg@redhat.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Michal Hocko <mhocko@suse.cz>,
David Rientjes <rientjes@google.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: + freezer-check-oom-kill-while-being-frozen.patch added to -mm tree
Date: Thu, 16 Oct 2014 23:11:36 +0200 [thread overview]
Message-ID: <20141016211136.GA27468@redhat.com> (raw)
In-Reply-To: <CAM_iQpUyCR3Bv1QhFkVmii9vB=fjMAUiWZ4T+mj60=FUZOXS+A@mail.gmail.com>
On 10/16, Cong Wang wrote:
>
> On Thu, Oct 16, 2014 at 1:39 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> >> Fix the issue by checking for TIF_MEMDIE thread flag and get away from the
> >> fridge if it is set. oom_scan_process_thread doesn't have to check for
> >> the frozen task anymore because do_send_sig_info will wake up the thread
> >> and TIF_MEMDIE is already set by that time.
> >
> > I must have missed something... but __refrigerator() sleeps in
> > TASK_UNINTERRUPTIBLE and do_send_sig_info() won't wake it up?
> >
>
> This is exactly what we are trying to fix. Make sure you read the patch
> as well before reply?
I did read the patch, but I can't understand it. I am sorry about that,
and I am asking for your help.
I agree that oom_scan_process_thread()->__thaw_task() doesn't really
help.
But also I can't understand why this patch helps. The changelog says:
do_send_sig_info will wake up the thread
why?
Oleg.
next prev parent reply other threads:[~2014-10-16 21:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 20:39 + freezer-check-oom-kill-while-being-frozen.patch added to -mm tree Oleg Nesterov
2014-10-16 20:53 ` Cong Wang
2014-10-16 21:11 ` Oleg Nesterov [this message]
2014-10-16 21:19 ` Cong Wang
2014-10-16 21:35 ` Oleg Nesterov
2014-10-16 21:52 ` Cong Wang
2014-10-16 22:22 ` Oleg Nesterov
2014-10-17 2:33 ` Cong Wang
2014-10-17 7:46 ` [PATCH -v2] freezer: check OOM kill while being frozen Michal Hocko
2014-10-17 16:10 ` Oleg Nesterov
2014-10-17 16:20 ` Michal Hocko
2014-10-20 15:17 ` Michal Hocko
2014-10-20 17:40 ` Oleg Nesterov
2014-10-17 15:24 ` + freezer-check-oom-kill-while-being-frozen.patch added to -mm tree Oleg Nesterov
2014-10-17 16:07 ` Michal Hocko
2014-10-17 6:59 ` Michal Hocko
2014-10-17 15:31 ` Oleg Nesterov
2014-10-17 16:06 ` Michal Hocko
-- strict thread matches above, loose matches on Subject: below --
2014-10-14 22:07 akpm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141016211136.GA27468@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=rjw@rjwysocki.net \
--cc=tj@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.