From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] tinyalsa: new package
Date: Sat, 18 Oct 2014 15:02:20 +0200 [thread overview]
Message-ID: <20141018150220.06b209c5@free-electrons.com> (raw)
In-Reply-To: <471202899.FpAt3MTFiF@hyperion>
Dear Maarten ter Huurne,
On Sat, 18 Oct 2014 02:42:45 +0200, Maarten ter Huurne wrote:
> > +++ b/package/tinyalsa/tinyalsa.mk
> > [snip]
> > + $(INSTALL) -D -m 0644 $(@D)/include/sound/asound.h \
> > + $(STAGING_DIR)/usr/include/sound/asound.h
>
> This will overwrite the pre-existing (from libc or kernel headers) version
> of <sound/asound.h> with the Android-style stripped version from tinyalsa.
> I think it would be better to keep the pre-existing version of this header,
> do you agree?
Yes, overwriting this header file indeed looks brutal. Is the original
asound.h a superset of the tinyalsa asound.h ? If that's the case, then
we can simply keep the original asound.h and that's it.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-18 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-05 17:51 [Buildroot] [PATCH] tinyalsa: new package Maxime Hadjinlian
2014-10-06 19:15 ` Thomas Petazzoni
2014-10-18 0:42 ` Maarten ter Huurne
2014-10-18 13:01 ` Maxime Hadjinlian
2014-10-18 13:02 ` Thomas Petazzoni [this message]
2014-10-18 13:19 ` Maxime Hadjinlian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141018150220.06b209c5@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.