All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Hall <mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
To: "Pattan, Reshma" <reshma.pattan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH RFC] librte_reorder: new reorder library
Date: Sat, 18 Oct 2014 10:26:34 -0700	[thread overview]
Message-ID: <20141018172634.GB16406@mhcomputing.net> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831FE240FC-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org>

On Fri, Oct 17, 2014 at 09:44:49AM +0000, Pattan, Reshma wrote:
> [Reshma]: Library just takes care of packets what it has got. No waiting 
> mechanism is used for missing packets.

> [Reshma]: This is dependent upon how frequently packets are enqueued and 
> dequeued from it. Packets which are in order and without gaps are dequeued 
> at the next call to the dequeue api. If there is a gap, the time taken to 
> skip over the gap will depend on the size of the reorder ring.

I am not sure this library will help much if it can't handle missing / delayed 
packets in some way.

When you're using a non-flow-aware distributor and moving packets around 
randomly / round robin / not using flows, you'll end up with some cases where 
a packet has some HOL blocking in some core and another later packet comes 
through faster on another core.

Maybe I missed something here, but I think there's got to be some logic where 
you can tell it's not ready to dequeue something yet, because there's a gap it 
needs to fill, or flows will break a lot due to race conditions I suspect.

Matthew.

      parent reply	other threads:[~2014-10-18 17:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07  9:33 [PATCH RFC] librte_reorder: new reorder library Pattan, Reshma
     [not found] ` <3AEA2BF9852C6F48A459DA490692831FE21954-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-07 11:21   ` Neil Horman
     [not found]     ` <20141007112155.GA27719-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-10-08 14:11       ` Pattan, Reshma
     [not found]         ` <3AEA2BF9852C6F48A459DA490692831FE2226C-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-08 19:15           ` Neil Horman
     [not found]             ` <20141008191546.GC13306-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-10-09 10:27               ` Pattan, Reshma
     [not found]                 ` <3AEA2BF9852C6F48A459DA490692831FE22552-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-09 11:36                   ` Neil Horman
     [not found]                     ` <20141009113650.GB20940-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-10-09 14:36                       ` Pattan, Reshma
     [not found]                         ` <3AEA2BF9852C6F48A459DA490692831FE22808-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-09 16:09                           ` Neil Horman
     [not found]                             ` <20141009160942.GE20940-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-10-09 17:21                               ` Matthew Hall
     [not found]                                 ` <20141009172134.GB8620-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-10-09 17:55                                   ` Neil Horman
2014-10-08 22:41   ` Matthew Hall
     [not found]     ` <20141008224111.GC29243-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-10-08 22:55       ` Neil Horman
     [not found]         ` <20141008225540.GA15850-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-10-08 23:07           ` Matthew Hall
     [not found]             ` <20141008230728.GA29712-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-10-09  9:14               ` Bruce Richardson
2014-10-09 17:11                 ` Matthew Hall
     [not found]                   ` <20141009171135.GA8620-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-10-10 10:59                     ` Bruce Richardson
2014-10-09 19:01   ` Jay Rolette
     [not found]     ` <CADNuJVpwfiC2x3joDnkgUX=fpEMe2MAS46ozkvojsaKy0=UGZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-17  9:44       ` Pattan, Reshma
     [not found]         ` <3AEA2BF9852C6F48A459DA490692831FE240FC-kPTMFJFq+rHjxeytcECX8bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-17 16:26           ` Jay Rolette
2014-10-18 17:26           ` Matthew Hall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141018172634.GB16406@mhcomputing.net \
    --to=mhall-hv3ognyu3jfzzajbqzqcxq@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=reshma.pattan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.