From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] mongrel2: Add comments to avoid use of github call
Date: Sun, 19 Oct 2014 10:58:46 +0200 [thread overview]
Message-ID: <20141019085846.GG4072@free.fr> (raw)
In-Reply-To: <1413142758-3356-1-git-send-email-maxime.hadjinlian@gmail.com>
Maxime, All,
On 2014-10-12 21:39 +0200, Maxime Hadjinlian spake thusly:
> As the comment says, we don't want to uses the github helper, as we
> would end up with a generated tarball, which is not the same one as the
> one linked with the releases.
>
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> v2 -> v3:
> - fix typo
> v1 -> v2:
> - Do not change the URL but add a comments instead
> ---
> package/mongrel2/mongrel2.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/mongrel2/mongrel2.mk b/package/mongrel2/mongrel2.mk
> index 14e3a80..23cec50 100644
> --- a/package/mongrel2/mongrel2.mk
> +++ b/package/mongrel2/mongrel2.mk
> @@ -5,6 +5,8 @@
> ################################################################################
>
> MONGREL2_VERSION = v1.9.1
> +# Do not use the github helper here, the generated tarball is *NOT* the same
> +# as the one uploaded by upstream for the release.
> MONGREL2_SITE = https://github.com/zedshaw/mongrel2/releases/download/$(MONGREL2_VERSION)
> MONGREL2_LICENSE = BSD-3c
> MONGREL2_LICENSE_FILES = LICENSE
> --
> 2.1.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-10-19 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 19:39 [Buildroot] [PATCH v3] mongrel2: Add comments to avoid use of github call Maxime Hadjinlian
2014-10-19 8:58 ` Yann E. MORIN [this message]
2014-10-30 21:51 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141019085846.GG4072@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.