From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] xlib_libpciaccess: Rename package to libpciaccess
Date: Sun, 19 Oct 2014 12:13:06 +0200 [thread overview]
Message-ID: <20141019121306.1a916f91@free-electrons.com> (raw)
In-Reply-To: <20141019121141.5098a140@free-electrons.com>
Hello,
Of course, I applied version 3, not version 2. I only replied to the
version 2 patch by mistake.
Thomas
On Sun, 19 Oct 2014 12:11:41 +0200, Thomas Petazzoni wrote:
> Dear Bernd Kuhls,
>
> On Fri, 17 Oct 2014 16:47:36 +0200, Bernd Kuhls wrote:
> > While libpciaccess is part of the X libraries, it does not
> > depend upon X11 or any other X library.
> >
> > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> > ---
> > v2: fixed stupid typo in package/Config.in
>
> Patch applied. I just have one comment/question below.
>
> > -$(eval $(autotools-package))
> > diff --git a/package/x11r7/xserver_xorg-server/Config.in b/package/x11r7/xserver_xorg-server/Config.in
> > index e191dce..4b90f3c 100644
> > --- a/package/x11r7/xserver_xorg-server/Config.in
> > +++ b/package/x11r7/xserver_xorg-server/Config.in
> > @@ -4,12 +4,12 @@ config BR2_PACKAGE_XSERVER_XORG_SERVER
> > # We need a SHA1 implementation. If either openssl or
> > # libgcrypt are already part of the build, we'll use one of
> > # them, otherwise, use the small libsha1 library.
> > + select BR2_PACKAGE_LIBPCIACCESS if BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR
>
> I know it's not a change you've made, but why do we need libpciaccess
> whenever the X.org modular server is enabled? I can imagine using the
> X.org modular server on ARM platforms that don't have any PCI hardware.
>
> Thanks,
>
> Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-19 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 14:47 [Buildroot] [PATCH v2 1/2] xlib_libpciaccess: Rename package to libpciaccess Bernd Kuhls
2014-10-17 14:47 ` [Buildroot] [PATCH v2 2/2] package/libva-intel-driver: Do not depend on xorg Bernd Kuhls
2014-10-18 14:24 ` Arnout Vandecappelle
2014-10-18 14:21 ` [Buildroot] [PATCH v2 1/2] xlib_libpciaccess: Rename package to libpciaccess Arnout Vandecappelle
2014-10-19 10:11 ` Thomas Petazzoni
2014-10-19 10:13 ` Thomas Petazzoni [this message]
2014-10-19 11:07 ` Bernd Kuhls
[not found] ` <E1XfoKe-0003Xk-Sb@fli4l.lan.fli4l>
2014-10-19 11:27 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141019121306.1a916f91@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.