All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Zapalowicz <bergo.torino@gmail.com>
To: Chen Weixiang <weixiangchen@gmail.com>
Cc: Marek Belisko <marek.belisko@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Chen Weixiang <weixiang.chen@gmail.com>,
	Greg Donald <gdonald@gmail.com>,
	Chen Gang <gang.chen.5i5j@gmail.com>,
	Artem Fetishev <wwctrsrx@gmail.com>,
	Andrey Utkin <andrey.krieger.utkin@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] staging: ft1000: space required after that ','
Date: Sun, 19 Oct 2014 15:27:00 +0200	[thread overview]
Message-ID: <20141019132700.GA3632@t400> (raw)
In-Reply-To: <1413723590-19690-4-git-send-email-weixiang.chen@gmail.com>

On 10/19, Chen Weixiang wrote:
> Remove code style error from ft1000/ft1000-usb/ft1000_debug.c:
> ERROR: space required after that ',' (ctx:VxV)
> 
> Signed-off-by: Chen Weixiang <weixiang.chen@gmail.com>
> ---
>  drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
> index 47dc0c0..183128c 100644
> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
> @@ -301,7 +301,7 @@ static int ft1000_open(struct inode *inode, struct file *file)
>  {
>  	struct ft1000_info *info;
>  	struct ft1000_usb *dev = (struct ft1000_usb *)inode->i_private;
> -    int i,num;
> +    int i, num;
>  
>      DEBUG("%s called\n", __func__);
>      num = (MINOR(inode->i_rdev) & 0xf);
> @@ -419,12 +419,12 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
>      struct timeval tv;
>  	struct IOCTL_GET_VER get_ver_data;
>  	struct IOCTL_GET_DSP_STAT get_stat_data;
> -    u8 ConnectionMsg[] = {0x00,0x44,0x10,0x20,0x80,0x00,0x00,0x00,0x00,0x00,0x03,0x00,0x00,0x00,0x93,0x64,
> -                          0x00,0x00,0x02,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x05,0x00,0x00,0x00,0x0a,
> -                          0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x02,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
> -                          0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
> -                          0x00,0x00,0x02,0x37,0x00,0x00,0x00,0x08,0x00,0x00,0x00,0x01,0x00,0x01,0x7f,0x00,
> -                          0x00,0x01,0x00,0x00};
> +    u8 ConnectionMsg[] = {0x00, 0x44, 0x10, 0x20, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, 0x93, 0x64,
> +                          0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x05, 0x00, 0x00, 0x00, 0x0a,
> +                          0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +                          0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x12, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +                          0x00, 0x00, 0x02, 0x37, 0x00, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00, 0x01, 0x00, 0x01, 0x7f, 0x00,
> +                          0x00, 0x01, 0x00, 0x00};

Nice, however it still violates the 80 characters a line rule. Please
redo this patch.

You can use the checkpatch to validate each patch befor sending and
generally you should aim towards sending patches with 0 checkpatch
warnings/errors. There is also the --strict option to the checkpatch
which is also worth uisng as some kernel subsystems use it as a default.

Thanks,
Konrad
  
>      unsigned short ledStat = 0;
>      unsigned short conStat = 0;
> @@ -475,7 +475,7 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
>              break;
>          }
>  
> -        DEBUG("FT1000:ft1000_ioctl:driver version = 0x%x\n",(unsigned int)get_ver_data.drv_ver);
> +        DEBUG("FT1000:ft1000_ioctl:driver version = 0x%x\n", (unsigned int)get_ver_data.drv_ver);
>  
>          break;
>      case IOCTL_CONNECT:
> @@ -652,7 +652,7 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
>                              }
>                              pmsg++;
>  				ppseudo_hdr = (struct pseudo_hdr *)pmsg;
> -                           result = card_send_command(ft1000dev,(unsigned short*)dpram_data,total_len+2);
> +                           result = card_send_command(ft1000dev, (unsigned short*)dpram_data, total_len+2);
>  
>  
>                              ft1000dev->app_info[app_index].nTxMsg++;
> -- 
> 2.1.1
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2014-10-19 13:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-19 12:59 [PATCH 0/7] Remove checkpatch.pl errors from drivers/staging/ft1000 Chen Weixiang
2014-10-19 12:59 ` [PATCH 1/7] staging: ft1000: do not initialise statics to 0 or NULL Chen Weixiang
2014-10-19 12:59 ` [PATCH 2/7] staging: ft1000: spaces required around that '=', '<' and '==' Chen Weixiang
2014-10-19 12:59 ` [PATCH 3/7] staging: ft1000: space required after that ',' Chen Weixiang
2014-10-19 13:27   ` Konrad Zapalowicz [this message]
2014-10-20 11:38     ` Chen Weixiang
2014-10-19 12:59 ` [PATCH 4/7] staging: ft1000: else should follow close brace '}' Chen Weixiang
2014-10-19 12:59 ` [PATCH 5/7] staging: ft1000: space prohibited after '(' and '&', before ')' Chen Weixiang
2014-10-19 12:59 ` [PATCH 6/7] staging: ft1000: "(foo*)" should be "(foo *)" Chen Weixiang
2014-10-19 12:59 ` [PATCH 7/7] staging: ft1000: "foo * bar" should be "foo *bar" Chen Weixiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141019132700.GA3632@t400 \
    --to=bergo.torino@gmail.com \
    --cc=andrey.krieger.utkin@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gang.chen.5i5j@gmail.com \
    --cc=gdonald@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.belisko@gmail.com \
    --cc=weixiang.chen@gmail.com \
    --cc=weixiangchen@gmail.com \
    --cc=wwctrsrx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.