Re: [PATCH 08/15] can: rx-fifo: fix long lines

[Marc Kleine-Budde <mkl@pengutronix.de>]

On Fri, Oct 10, 2014 at 05:46:53PM +0200, David Jander wrote:
> Signed-off-by: David Jander <david@protonic.nl>
> ---
>  drivers/net/can/dev.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
> index 22a3955..3e1160a 100644
> --- a/drivers/net/can/dev.c
> +++ b/drivers/net/can/dev.c
> @@ -301,17 +301,21 @@ static unsigned int can_rx_fifo_inc(struct can_rx_fifo *fifo, unsigned int *val)
>  static u64 can_rx_fifo_mask_low(struct can_rx_fifo *fifo)
>  {
>  	if (fifo->inc)
> -		return ~0LLU >> (64 + fifo->low_first - fifo->high_first) << fifo->low_first;
> +		return ~0LLU >> (64 + fifo->low_first - fifo->high_first)
> +			     << fifo->low_first;

In the kernel, a line usually doesn't start with an operator. Please keep it in
the original line.

>  	else
> -		return ~0LLU >> (64 - fifo->low_first + fifo->high_first) << (fifo->high_first + 1);
> +		return ~0LLU >> (64 - fifo->low_first + fifo->high_first)
> +			     << (fifo->high_first + 1);
>  }
>  
>  static u64 can_rx_fifo_mask_high(struct can_rx_fifo *fifo)
>  {
>  	if (fifo->inc)
> -		return ~0LLU >> (64 + fifo->high_first - fifo->high_last - 1) << fifo->high_first;
> +		return ~0LLU >> (64 + fifo->high_first - fifo->high_last - 1)
> +			     << fifo->high_first;
>  	else
> -		return ~0LLU >> (64 - fifo->high_first + fifo->high_last - 1) << fifo->high_last;
> +		return ~0LLU >> (64 - fifo->high_first + fifo->high_last - 1)
> +			     << fifo->high_last;
>  }
>  
>  static int can_rx_fifo_read_napi_frame(struct can_rx_fifo *fifo, int index)

Marc

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |