All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 24/31] ffmpeg: use arch and cpu instead of tune
Date: Mon, 20 Oct 2014 00:09:00 +0200	[thread overview]
Message-ID: <20141019220900.GE12247@free.fr> (raw)
In-Reply-To: <1413749285-1108-25-git-send-email-thomas.petazzoni@free-electrons.com>

Thomas, All,

On 2014-10-19 22:07 +0200, Thomas Petazzoni spake thusly:
> ffmpeg currently uses BR2_GCC_TARGET_TUNE as the --cpu option
> value. However, there are multiple architectures for which
> BR2_GCC_TARGET_TUNE is not used. After inspecting the ffmpeg configure
> script, we concluded that using the BR2_GCC_TARGET_CPU value if
> available, or the BR2_GCC_TARGET_ARCH value as a fallback was the
> appropriate behavior.
> 
> This allows to remove the reference to BR2_GCC_TARGET_TUNE, which is
> one step towards the removal of this option.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/ffmpeg/ffmpeg.mk | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk
> index a3865f3..6c8b899 100644
> --- a/package/ffmpeg/ffmpeg.mk
> +++ b/package/ffmpeg/ffmpeg.mk
> @@ -334,6 +334,12 @@ endif
>  
>  FFMPEG_CONF_OPTS += $(call qstrip,$(BR2_PACKAGE_FFMPEG_EXTRACONF))
>  
> +ifneq ($(call qstrip,$(BR2_GCC_TARGET_CPU)),)
> +FFMPEG_CONF_OPTS += --cpu=$(BR2_GCC_TARGET_CPU)
> +else ifneq ($(call qstrip,$(BR2_GCC_TARGET_ARCH),)
> +FFMPEG_CONF_OPTS += --cpu=$(BR2_GCC_TARGET_ARCH)
> +endif
> +
>  # Override FFMPEG_CONFIGURE_CMDS: FFmpeg does not support --target and others
>  define FFMPEG_CONFIGURE_CMDS
>  	(cd $(FFMPEG_SRCDIR) && rm -rf config.cache && \
> @@ -349,7 +355,6 @@ define FFMPEG_CONFIGURE_CMDS
>  		--target-os="linux" \
>  		--disable-stripping \
>  		--pkg-config="$(PKG_CONFIG_HOST_BINARY)" \
> -		$(if $(BR2_GCC_TARGET_TUNE),--cpu=$(BR2_GCC_TARGET_TUNE)) \
>  		$(SHARED_STATIC_LIBS_OPTS) \
>  		$(FFMPEG_CONF_OPTS) \
>  	)
> -- 
> 2.0.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-10-19 22:09 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-19 20:07 [Buildroot] [PATCH 00/31] Removal of BR2_GCC_TARGET_TUNE and other arch/ updates Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 01/31] ffmpeg: remove dangling reference to BR2_arm10 Thomas Petazzoni
2014-10-19 21:34   ` Yann E. MORIN
2014-10-20  8:35   ` Samuel Martin
2014-10-20  9:10   ` Peter Korsgaard
2014-10-19 20:07 ` [Buildroot] [PATCH 02/31] libplayer: fix typo on BR2_nios2 Thomas Petazzoni
2014-10-19 21:34   ` Yann E. MORIN
2014-10-20  8:35   ` Samuel Martin
2014-10-20  9:11   ` Peter Korsgaard
2014-10-19 20:07 ` [Buildroot] [PATCH 03/31] arch/arm: add blind options to know the ARM architecture Thomas Petazzoni
2014-10-19 21:55   ` Yann E. MORIN
2014-10-20 20:03     ` Arnout Vandecappelle
2014-10-21 17:03     ` Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 04/31] ffmpeg: use the new BR2_ARM_CPU_ARM* options Thomas Petazzoni
2014-10-20 20:12   ` Arnout Vandecappelle
2014-10-19 20:07 ` [Buildroot] [PATCH 05/31] gst-ffmpeg: " Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 06/31] gst-ffmpeg: allow usage of ARMv6 optimizations on ARMv7 platforms Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 07/31] gst1-libav: use the new BR2_ARM_CPU_ARM* options Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 08/31] gst1-libav: allow usage of ARMv6 optimizations on ARMv7 platforms Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 09/31] mplayer: use BR2_ARM_CPU_ARM* options Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 10/31] libplayer: use BR2_ARM_CPU_ARM* option Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 11/31] nettle: use the BR2_ARM_CPU_ARM* options Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 12/31] nodejs: use " Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 13/31] qt5: use the " Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 14/31] speex: use " Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 15/31] vo-aacenc: use the " Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 16/31] webkit: use " Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 17/31] valgrind: use the " Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 18/31] x264: use the BR2_ARM_CPU_ARMV7A option Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 19/31] libnspr: " Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 20/31] toolchain-external: use BR2_ARM_CPU_ARM* options Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 21/31] dhcpcd: do not pass --target option Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 22/31] arch/arm: do not distinguish revisions of ARM1136JF-S Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 23/31] arch/arm: remove BR2_GCC_TARGET_ARCH definitions on ARM Thomas Petazzoni
2014-10-19 20:07 ` [Buildroot] [PATCH 24/31] ffmpeg: use arch and cpu instead of tune Thomas Petazzoni
2014-10-19 22:09   ` Yann E. MORIN [this message]
2014-10-19 20:07 ` [Buildroot] [PATCH 25/31] arch/x86: get rid of BR2_GCC_TARGET_TUNE Thomas Petazzoni
2014-10-19 22:10   ` Yann E. MORIN
2014-10-19 20:08 ` [Buildroot] [PATCH 26/31] arch/sparc: " Thomas Petazzoni
2014-10-19 22:13   ` Yann E. MORIN
2014-10-19 20:08 ` [Buildroot] [PATCH 27/31] arch/powerpc: " Thomas Petazzoni
2014-10-19 22:17   ` Yann E. MORIN
2014-10-19 20:08 ` [Buildroot] [PATCH 28/31] arch/m68k: " Thomas Petazzoni
2014-10-19 22:18   ` Yann E. MORIN
2014-10-19 20:08 ` [Buildroot] [PATCH 29/31] gcc: do not use BR2_GCC_TARGET_TUNE anymore Thomas Petazzoni
2014-10-19 22:18   ` Yann E. MORIN
2014-10-19 20:08 ` [Buildroot] [PATCH 30/31] toolchain-external: " Thomas Petazzoni
2014-10-19 20:08 ` [Buildroot] [PATCH 31/31] arch: remove the BR2_GCC_TARGET_TUNE option Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141019220900.GE12247@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.