From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: use the gnu89 standard explicitly
Date: Mon, 20 Oct 2014 01:29:28 +0300 [thread overview]
Message-ID: <20141019222928.GA9319@node.dhcp.inet.fi> (raw)
In-Reply-To: <1413734862-13510-1-git-send-email-sasha.levin@oracle.com>
On Sun, Oct 19, 2014 at 12:07:42PM -0400, Sasha Levin wrote:
> gcc5 changes the default standard to c11, rather than gnu89, which
> makes kernel build unhappy.
>
> Explicitly define the kernel standard to be gnu89 which should
> keep everything working exactly like it was before gcc5.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
> Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index dd7e1cb..43f31cb 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -642,7 +642,8 @@ ifdef CONFIG_READABLE_ASM
> # partial inlining inlines only parts of functions
> KBUILD_CFLAGS += $(call cc-option,-fno-reorder-blocks,) \
> $(call cc-option,-fno-ipa-cp-clone,) \
> - $(call cc-option,-fno-partial-inlining)
> + $(call cc-option,-fno-partial-inlining,) \
> + $(call cc-option,-std=gnu89)
> endif
Hm. Why is that under #ifdef CONFIG_READABLE_ASM ?
--
Kirill A. Shutemov
prev parent reply other threads:[~2014-10-19 22:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 16:07 [PATCH] kernel: use the gnu89 standard explicitly Sasha Levin
2014-10-19 20:05 ` Linus Torvalds
2014-10-19 20:23 ` Joe Perches
[not found] ` <CA+55aFwbq4TtQXC9PTjOF3UPP7u8XH1mSYjvT7pevKcQBfy25A@mail.gmail.com>
2014-10-19 21:31 ` Joe Perches
2014-10-19 21:03 ` Aaro Koskinen
2014-10-19 23:05 ` Linus Torvalds
2014-10-19 23:10 ` Kirill A. Shutemov
2014-10-19 23:19 ` Al Viro
2014-10-19 23:21 ` Kirill A. Shutemov
2014-10-19 23:26 ` Al Viro
2014-10-19 23:49 ` Linus Torvalds
2014-10-19 23:59 ` Sasha Levin
2014-10-20 0:23 ` Linus Torvalds
2014-10-20 4:16 ` Al Viro
2014-10-19 23:25 ` pinskia
2014-10-19 23:52 ` Sasha Levin
2014-10-19 22:29 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141019222928.GA9319@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.