All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: Paul Eggleton <paul.eggleton@linux.intel.com>,
	Koen Kooi <koen@dominion.thruhere.net>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 4/7] kernel: Pull uImage generation into separate class
Date: Mon, 20 Oct 2014 00:29:22 +0200	[thread overview]
Message-ID: <201410200029.22491.marex@denx.de> (raw)
In-Reply-To: <CADkTA4PhjW0vDu2tDW+FzBvOSLf7YSO7Zzzr3T2XGaZMs1k5hw@mail.gmail.com>

On Monday, October 20, 2014 at 12:08:57 AM, Bruce Ashfield wrote:
> On Sun, Oct 19, 2014 at 3:15 PM, Marek Vasut <marex@denx.de> wrote:
> > Pull the uImage image format generation from kernel.bbclass into
> > a separate kernel-uimage.bbclass. The recipes which now need to
> > generate an uImage will have to inherit kernel-uimage instead of
> > kernel class.
> 
> The commit log doesn't tell us why. What's the benefit or functionality we
> gain via the change ?

Ah right. I will be recycling some of those functions later on in the fitImage 
support. Also, it was suggested to me that there should be a separate class for
each image type -- that all the image types should not be in kernel.bbclass .

Does that make sense please?

Best regards,
Marek Vasut


  reply	other threads:[~2014-10-19 22:31 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-19 19:15 [PATCH 0/7] Add basic fitImage support Marek Vasut
2014-10-19 19:15 ` [PATCH 1/7] kernel: Clean up KERNEL_IMAGETYPE_FOR_MAKE Marek Vasut
2014-10-19 19:25   ` Otavio Salvador
2014-10-19 21:13     ` Marek Vasut
2014-10-19 21:26       ` Otavio Salvador
2014-10-22 20:39         ` Marek Vasut
2014-10-23  0:32           ` Otavio Salvador
2014-10-23  0:45             ` Marek Vasut
2014-10-19 19:15 ` [PATCH 2/7] kernel: Rework do_uboot_mkimage Marek Vasut
2014-10-19 19:15 ` [PATCH 3/7] kernel: Pull out the linux.bin generation Marek Vasut
2014-10-19 19:15 ` [PATCH 4/7] kernel: Pull uImage generation into separate class Marek Vasut
2014-10-19 21:29   ` Khem Raj
2014-10-19 22:31     ` Marek Vasut
2014-10-19 22:08   ` Bruce Ashfield
2014-10-19 22:29     ` Marek Vasut [this message]
2014-10-20  3:38       ` Bruce Ashfield
2014-10-20 10:26   ` Koen Kooi
2014-10-21 23:28     ` Marek Vasut
2014-10-22  8:42       ` Koen Kooi
2014-10-22 21:45         ` Marek Vasut
2014-10-26 11:29           ` Koen Kooi
2014-10-26 22:52             ` Marek Vasut
2014-10-27  6:59               ` Koen Kooi
2015-04-28  2:39                 ` Marek Vasut
2015-04-28  8:22                   ` Paul Eggleton
2014-10-22 20:51     ` Marek Vasut
2014-10-19 19:15 ` [PATCH 5/7] kernel: Separate out uboot_prep_kimage Marek Vasut
2014-10-19 19:15 ` [PATCH 6/7] kernel: Build DTBs early Marek Vasut
2014-10-19 19:15 ` [PATCH 7/7] kernel: Add basic fitImage support Marek Vasut
2014-10-19 19:32 ` [PATCH 0/7] " Otavio Salvador
2015-04-28  1:32   ` Marek Vasut
2014-10-22 23:26 ` Burton, Ross
2014-10-23  0:01   ` Marek Vasut
2015-04-28  1:09   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201410200029.22491.marex@denx.de \
    --to=marex@denx.de \
    --cc=bruce.ashfield@gmail.com \
    --cc=koen@dominion.thruhere.net \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.