From: Florian Westphal <fw@strlen.de>
To: David Miller <davem@davemloft.net>
Cc: fw@strlen.de, netdev@vger.kernel.org, edumazet@google.com
Subject: Re: [PATCH 2/4] net: make skb_gso_segment error handling more robust
Date: Mon, 20 Oct 2014 09:05:04 +0200 [thread overview]
Message-ID: <20141020070504.GC4626@breakpoint.cc> (raw)
In-Reply-To: <20141019.203943.579204096575757665.davem@davemloft.net>
David Miller <davem@davemloft.net> wrote:
> From: Florian Westphal <fw@strlen.de>
> Date: Sun, 19 Oct 2014 22:42:19 +0200
>
> > skb_gso_segment has three possible return values:
> > 1. a pointer to the first segmented skb
> > 2. an errno value (IS_ERR())
> > 3. NULL. This can happen when GSO is used for header verification.
> >
> > However, several callers currently test IS_ERR instead of IS_ERR_OR_NULL
> > and would oops when NULL is returned.
> >
> > Note that these call sites should never actually see such a NULL return
> > value; all callers mask out the GSO bits in the feature argument.
> >
> > However, in the past, there have been issues with some protocol handlers
> > erronously not respecting the specified feature mask in some cases.
> >
> > Signed-off-by: Florian Westphal <fw@strlen.de>
>
> I don't think it makes sense to return PTR_ERR(p) when
> p is NULL.
Good point. Will respin.
next prev parent reply other threads:[~2014-10-20 7:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 20:42 [PATCH 0/3] net: minor gso encapsulation fixes Florian Westphal
2014-10-19 20:42 ` [PATCH 1/4] net: gso: use feature flag argument in all protocol gso handlers Florian Westphal
2014-10-19 20:42 ` [PATCH 2/4] net: make skb_gso_segment error handling more robust Florian Westphal
2014-10-20 0:39 ` David Miller
2014-10-20 7:05 ` Florian Westphal [this message]
2014-10-19 20:42 ` [PATCH 3/4] net: core: handle encapsulation offloads when computing segment lengths Florian Westphal
2014-10-19 20:55 ` [PATCH 0/3] net: minor gso encapsulation fixes Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141020070504.GC4626@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.