From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, shuang.he@linux.intel.com
Subject: Re: [PATCH 2/2] drm/i915: spt does not have pch backlight override bit
Date: Mon, 20 Oct 2014 14:28:48 +0300 [thread overview]
Message-ID: <20141020112848.GW4284@intel.com> (raw)
In-Reply-To: <1412952813-4060-2-git-send-email-jani.nikula@intel.com>
On Fri, Oct 10, 2014 at 05:53:33PM +0300, Jani Nikula wrote:
> SPT is always in the PCH override mode, and the bit MBZ. Only set
> override on LPT.
>
> v2: check for PCH version (Ville)
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_panel.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
> index e3def5ad4a77..e18b3f49074c 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -775,8 +775,9 @@ static void bdw_enable_backlight(struct intel_connector *connector)
> if (panel->backlight.active_low_pwm)
> pch_ctl1 |= BLM_PCH_POLARITY;
>
> - /* BDW always uses the pch pwm controls. */
> - pch_ctl1 |= BLM_PCH_OVERRIDE_ENABLE;
> + /* After LPT, override is the default. */
> + if (HAS_PCH_LPT(dev_priv))
> + pch_ctl1 |= BLM_PCH_OVERRIDE_ENABLE;
>
> I915_WRITE(BLC_PWM_PCH_CTL1, pch_ctl1);
> POSTING_READ(BLC_PWM_PCH_CTL1);
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2014-10-20 11:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 14:53 [PATCH 1/2] drm/i915: allow dev_priv for HAS_PCH_* macros too Jani Nikula
2014-10-10 14:53 ` [PATCH 2/2] drm/i915: spt does not have pch backlight override bit Jani Nikula
2014-10-11 8:28 ` [PATCH 2/2] drm/i915: spt does not have pch backlight shuang.he
2014-10-20 11:28 ` Ville Syrjälä [this message]
2014-10-10 14:58 ` [PATCH 1/2] drm/i915: allow dev_priv for HAS_PCH_* macros too Chris Wilson
2014-10-10 15:10 ` Jani Nikula
2014-10-21 14:57 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141020112848.GW4284@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=shuang.he@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.