From: Josh Triplett <josh@joshtriplett.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Aristeu Rozanski <aris@redhat.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP
Date: Mon, 20 Oct 2014 04:55:11 -0700 [thread overview]
Message-ID: <20141020115511.GA28133@thin> (raw)
In-Reply-To: <1413798151.10246.10.camel@jlt4.sipsolutions.net>
On Mon, Oct 20, 2014 at 11:42:31AM +0200, Johannes Berg wrote:
> On Thu, 2014-10-16 at 11:49 -0400, Aristeu Rozanski wrote:
> > It's desirable for allnconfig and tinyconfig targets to result in the
> > least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
> > switch off DEV_COREDUMP regardless if any drivers select
> > WANT_DEV_COREDUMP.
> >
> > This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
> > 'n' (as in allnconfig or tinyconfig) will effectively disable device
> > coredump.
> >
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Josh Triplett <josh@joshtriplett.org>
> > Cc: Johannes Berg <johannes@sipsolutions.net>
>
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
> Acked-by: Johannes Berg <johannes@sipsolutions.net>
>
> Yeah, looks sensible, and should work.
Thanks.
I've added this to the tiny/reverse-dev-coredump branch of my
tinification tree at
https://git.kernel.org/cgit/linux/kernel/git/josh/linux.git/ , with
Johannes' review, and I'll push it upstream during the 3.19 merge
window.
- Josh Triplett
next prev parent reply other threads:[~2014-10-20 11:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 13:36 [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP Aristeu Rozanski
2014-10-16 13:44 ` Josh Triplett
2014-10-16 15:49 ` Aristeu Rozanski
2014-10-20 9:42 ` Johannes Berg
2014-10-20 11:55 ` Josh Triplett [this message]
2014-10-20 22:18 ` Greg Kroah-Hartman
2014-10-20 23:45 ` josh
2014-10-30 8:01 ` Johannes Berg
2014-10-30 9:00 ` [PATCH 3.18] tiny: rename ENABLE_DEV_COREDUMP to ALLOW_DEV_COREDUMP Johannes Berg
2014-10-30 12:55 ` Aristeu Rozanski
2014-10-30 13:32 ` Josh Triplett
-- strict thread matches above, loose matches on Subject: below --
2014-10-15 15:25 [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP Aristeu Rozanski
2014-10-15 23:14 ` Greg Kroah-Hartman
2014-10-16 3:51 ` Josh Triplett
2014-10-16 10:18 ` Greg Kroah-Hartman
2014-10-16 10:24 ` Josh Triplett
2014-10-16 13:02 ` Aristeu Rozanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141020115511.GA28133@thin \
--to=josh@joshtriplett.org \
--cc=aris@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.