All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Alfonso Acosta <fons@spotify.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v4 2/2] core: Add subscription API for Manufacturer Specific Data
Date: Mon, 20 Oct 2014 15:42:06 +0200	[thread overview]
Message-ID: <20141020134206.GB31414@t440s> (raw)
In-Reply-To: <1413290765-20398-3-git-send-email-fons@spotify.com>

Hi Alfonso,

On Tue, Oct 14, 2014, Alfonso Acosta wrote:
> This patch allows plugins to be notified whenever an adapter receives
> Manufacturer Specific Data in the advertising reports from a device.
> 
> This can happen when new device is discovered or when we autoconnect
> to it.
> ---
>  src/adapter.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
>  src/adapter.h | 10 ++++++++++
>  2 files changed, 54 insertions(+)

This patch also doesn't compile (the error from the first patch might
have gone away, but then there's this new one):

src/adapter.c:4654:6: error: no previous declaration for ‘adapter_msd_notify’ [-Werror=missing-declarations]
 void adapter_msd_notify(struct btd_adapter *adapter, struct btd_device *dev,
      ^
cc1: all warnings being treated as errors
make[1]: *** [src/bluetoothd-adapter.o] Error 1


Johan

  reply	other threads:[~2014-10-20 13:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-14 12:46 [PATCH v4 0/2] core: Add plugin-support for Manufacturer Specific Data EIR Alfonso Acosta
2014-10-14 12:46 ` [PATCH v4 1/2] core: Add Manufacturer Specific Data EIR field Alfonso Acosta
2014-10-20 13:41   ` Johan Hedberg
2014-10-20 14:54     ` Alfonso Acosta
2014-10-14 12:46 ` [PATCH v4 2/2] core: Add subscription API for Manufacturer Specific Data Alfonso Acosta
2014-10-20 13:42   ` Johan Hedberg [this message]
     [not found]     ` <CAHF=Y4q0ZRbGAUMtMi5vA13hQFn8JCmu+7B1rLdRxDSO6jxiCg@mail.gmail.com>
2014-10-20 14:53       ` Alfonso Acosta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141020134206.GB31414@t440s \
    --to=johan.hedberg@gmail.com \
    --cc=fons@spotify.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.