From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Add KEYS_COMPAT to Kconfig & enable
Date: Mon, 20 Oct 2014 17:10:17 +0100 [thread overview]
Message-ID: <20141020161017.GL20301@arm.com> (raw)
In-Reply-To: <1413316871-27404-1-git-send-email-spang@chromium.org>
On Tue, Oct 14, 2014 at 09:01:11PM +0100, Michael Spang wrote:
> This enables the keyctl compat syscall.
>
> Signed-off-by: Michael Spang <spang@chromium.org>
> ---
> arch/arm64/Kconfig | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index ac9afde..35c3103 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -461,6 +461,11 @@ source "arch/arm64/Kconfig.debug"
>
> source "security/Kconfig"
>
> +config KEYS_COMPAT
> + bool
> + depends on COMPAT && KEYS
> + default y
I'm curious as to why this requires a Kconfig option, whilst other compat
system calls do not. The core code is already using COMPAT_SYSCALL_DEFINE,
so why can't the architecture just plumb the compat syscall table and be
done with it?
Failing that, the pattern used elsewhere involves __ARCH_WANT_COMPAT_*
#defines.
Will
next prev parent reply other threads:[~2014-10-20 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 20:01 [PATCH] arm64: Add KEYS_COMPAT to Kconfig & enable Michael Spang
2014-10-20 16:10 ` Will Deacon [this message]
2015-04-20 21:20 ` Michael Spang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141020161017.GL20301@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.