All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/boost: enable building of boost_log
Date: Mon, 20 Oct 2014 19:07:03 +0200	[thread overview]
Message-ID: <20141020170703.GE3742@free.fr> (raw)
In-Reply-To: <20141020170223.GC3742@free.fr>

Yannick, All,

On 2014-10-20 19:02 +0200, Yann E. MORIN spake thusly:
> On 2014-10-20 15:27 +0200, Yannick Kiekens spake thusly:
[--SNIP--]
> > diff --git a/package/boost/boost.mk b/package/boost/boost.mk
> > index 46a98e8..06969b4 100644
> > --- a/package/boost/boost.mk
> > +++ b/package/boost/boost.mk
> > @@ -25,8 +25,7 @@ HOST_BOOST_FLAGS = --without-icu \
> >  
> >  # atomic library compile only with upstream version, wait for next release
> >  # coroutine breaks on some weak toolchains and it's new for 1.54+
> > -# log breaks with some toolchain combinations and it's new for 1.54+
> 
> As you remove a comment that warns that log is broken in some cases, it
> would be nice if you were to explain why this comment no longer applies.
> 
> For example, you could format your commit log as thus (reason totally
> made up for the sake of the example, adapt):
> 
>     package/boost: enable building of boost_log
> 
>     In the current version of boost, boost_log is now considered stable
>     and maintained. The failures caused by "some toolchain combinations"
>     no longer occur.
> 
>     Signed-off-by: [YOU]
> 
>     ---
>     Tested with these toolchains:
>       - uClibc, arm, static only
>       - uClibc, x86_64
> 
> Note the '---' line: you can add such a line in your commit log, and it
> will appear as-is in the mail you send. However, git is smart enough so
> that when the maintainer applies the patch, git removes it.

Sorry, I meant:
    [...] git removes it, and whatever follows (but keeps the patch, of
    course).

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-10-20 17:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20 13:27 [Buildroot] [PATCH 1/1] package/boost: enable building of boost_log Yannick Kiekens
2014-10-20 17:02 ` Yann E. MORIN
2014-10-20 17:07   ` Yann E. MORIN [this message]
2014-10-21  7:15     ` Yannick Kiekens
2014-10-21  9:56       ` Thomas Petazzoni
2015-03-15 16:49 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141020170703.GE3742@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.