From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Ruder Date: Mon, 20 Oct 2014 14:39:41 -0500 Subject: [U-Boot] [PATCH 2/3] dm9000: Add struct eth_device * to SROM functions In-Reply-To: <20141020191713.GR25506@bill-the-cat> References: <1413817185-32636-1-git-send-email-andrew.ruder@elecsyscorp.com> <1413817185-32636-3-git-send-email-andrew.ruder@elecsyscorp.com> <20141020191713.GR25506@bill-the-cat> Message-ID: <20141020193940.GB10047@og3k> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Oct 20, 2014 at 03:17:13PM -0400, Tom Rini wrote: > You shouldn't have to add this to avoid a warning I think. And frankly, > if it does for some reason since 3/3 makes use of dev, I'm OK with a > bisect adding a trivial warning like this, rather than do compiler > games. Fair enough, the more I look at it, the more it looks like I probably missed a warning on this patch + CONFIG_DM9000_NO_SROM (defined but not used) so it is still pretty easy to trigger a warning on this patch. I'll just remove the indicated parts in v2 of the series and let the warnings get cleaned up in 3/3 as you have suggested. Will send a v2 of series in a bit after seeing if there is any feedback on the approaches used in 3/3. - Andy