From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Sasha Levin <sasha.levin@oracle.com>,
paulmck@linux.vnet.ibm.com,
Nikolay Aleksandrov <nikolay@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ursula Braun <braunu@de.ibm.com>
Subject: Re: [PATCH] netlink: Re-add locking to netlink_lookup() and seq walker
Date: Tue, 21 Oct 2014 09:04:24 +0200 [thread overview]
Message-ID: <20141021070424.GA4161@osiris> (raw)
In-Reply-To: <20141020195355.GA2299@casper.infradead.org>
On Mon, Oct 20, 2014 at 08:53:55PM +0100, Thomas Graf wrote:
> Heiko,
>
> Can you test the following patch:
>
> The synchronize_rcu() in netlink_release() introduces unacceptable
> latency. Reintroduce minimal lookup so we can drop the
> synchronize_rcu() until socket destruction has been RCUfied.
>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
> ---
> net/netlink/af_netlink.c | 37 +++++++++++++++++++++++++------------
> 1 file changed, 25 insertions(+), 12 deletions(-)
Thanks a lot! Your patch fixes the issue for me.
Reported-and-tested-by: Heiko Carstens <heiko.carstens@de.ibm.com>
next prev parent reply other threads:[~2014-10-21 7:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 8:36 [bisected] e341694e3eb5 netlink_lookup() rcu conversion causes latencies Heiko Carstens
2014-10-11 19:32 ` Eric Dumazet
2014-10-11 22:25 ` Thomas Graf
2014-10-11 23:08 ` David Miller
2014-10-20 8:21 ` Heiko Carstens
2014-10-20 19:53 ` [PATCH] netlink: Re-add locking to netlink_lookup() and seq walker Thomas Graf
2014-10-21 7:04 ` Heiko Carstens [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-21 20:05 Thomas Graf
2014-10-22 1:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021070424.GA4161@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=braunu@de.ibm.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sasha.levin@oracle.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.