From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH for-xen-4.5] Add configure
	--with-extra-cflags-*
Date: Tue, 21 Oct 2014 11:03:35 +0200
Message-ID: <20141021090335.GA17073@aepfle.de>
References: <1412847832-24047-1-git-send-email-olaf@aepfle.de>
	<20141010065557.GA24574@aepfle.de>
	<1413808777.4087.14.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1413808777.4087.14.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, Oct 20, Ian Campbell wrote:

> It looks to me like seabios_path isn't, so I'm confused about what you
> are trying to suggest:
> 
> AC_ARG_WITH([system-seabios],
>     AS_HELP_STRING([--with-system-seabios@<:@=PATH@:>@],
>        [Use system supplied seabios PATH instead of building and installing
>         our own version]),[
>     case $withval in
>         no) seabios_path= ;;
>         *)  seabios_path=$withval ;;
>     esac
> ],[])
> AC_SUBST(seabios_path)
> 
> Doesn't take anything fro the env, does it?

I just tried today:

# git clean -dfx
# env EXTRA_QEMUU_CONFIGURE_ARGS=XXXXXXXXXXXXXXXX ./configure &>/dev/null
#  grep XXXXXXXXXXXXXXXX config/Tools.mk
CONFIG_QEMUU_EXTRA_ARGS:= XXXXXXXXXXXXXXXX

The empty [] in AC_ARG_WITH() is what is supposed to be executed if
--with*-foo was not specified. In this case nothing will be done with
EXTRA_QEMUU_CONFIGURE_ARGS. Later AC_SUBST() takes the environment
variable and does the substitution.  And the same happens if I replace
"EXTRA_QEMUU_CONFIGURE_ARGS" with "seabios_path" in my example.

I think this should not happen. To fix it the empty [] should be filled
with "variable=", like "seabios_path=".

What do you think?

> >  I also
> > question if --with-foo=no is useful at all.
> 
> Isn't $withval=no the result of passing --without-foo?

Yes, looks like it. I will update my patch to handle also the "no" due
to --without-extra-cflags-*.


Olaf