All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Pieter Smith <pieter@boesman.nl>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Eric Paris <eparis@redhat.com>, Matt Turner <mattst88@gmail.com>,
	Michal Hocko <mhocko@suse.cz>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Fabian Frederick <fabf@skynet.be>, Tejun Heo <tj@kernel.org>,
	????????? <zhenglong.cai@cs2c.com.cn>,
	"Luis R. Rodriguez" <mcgrof@suse.com>,
	Peter Foley <pefoley2@pefoley.com>,
	Konstantin Khlebnikov <koct9i@gmail.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Oleg Nesterov <oleg@redhat.com>,
	Andy Lutomirski <luto@amacapital.net>,
	David Herrmann <dh.herrmann@gmail.com>,
	Kees Cook <keescook@chromium.org>,
	linux-fsdevel@vger.kernel.org,
	open list <linux-kernel@vger.kernel.org>,
	"open list:ABI/API" <linux-api@vger.kernel.org>
Subject: Re: [PATCH 2/2] fs: Support compiling out sendfile
Date: Tue, 21 Oct 2014 02:04:22 -0700	[thread overview]
Message-ID: <20141021090421.GB17604@thin> (raw)
In-Reply-To: <20141021075154.GB10020@infradead.org>

On Tue, Oct 21, 2014 at 12:51:54AM -0700, Christoph Hellwig wrote:
> On Mon, Oct 20, 2014 at 03:24:22PM -0700, josh@joshtriplett.org wrote:
> > On Mon, Oct 20, 2014 at 11:48:37PM +0200, Pieter Smith wrote:
> > > Many embedded systems will not need this syscall, and omitting it
> > > saves space.  Add a new EXPERT config option CONFIG_SENDFILE_SYSCALL
> > > (default y) to support compiling it out.
> > 
> > Nice work, thanks!
> > 
> > If there are no objections, and nobody has a tree they'd rather carry
> > this through, I'll take the series through the tiny tree when it's ready
> > to merge.
> 
> I think it's rather pointless - there is very little sendfile code,
> so you'd rather want to disable splice.

That's the plan, but since sendfile depends on some of the splice bits,
sendfile needs to be optional as well; SENDFILE_SYSCALL will then select
SPLICE_SYSCALLS.

- Josh Triplett

  reply	other threads:[~2014-10-21  9:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20 21:48 [PATCH 1/2] fs: Moved sendfile syscall to own source file Pieter Smith
     [not found] ` <1413841728-1313-1-git-send-email-pieter-qeJ+1H9vRZbz+pZb47iToQ@public.gmane.org>
2014-10-20 21:48   ` [PATCH 2/2] fs: Support compiling out sendfile Pieter Smith
2014-10-20 21:48     ` Pieter Smith
2014-10-20 21:48     ` Pieter Smith
2014-10-20 22:24     ` josh
2014-10-21  7:51       ` Christoph Hellwig
2014-10-21  7:51         ` Christoph Hellwig
2014-10-21  9:04         ` Josh Triplett [this message]
2014-10-21  9:13           ` Christoph Hellwig
2014-10-21  9:50             ` Josh Triplett
     [not found]     ` <54467D9C.2030302@zytor.com>
     [not found]       ` <20141021171814.GA14704@cloud>
2014-10-21 17:20         ` Eric Paris
2014-10-20 22:03 ` [PATCH 1/2] fs: Moved sendfile syscall to own source file josh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141021090421.GB17604@thin \
    --to=josh@joshtriplett.org \
    --cc=akpm@linux-foundation.org \
    --cc=dh.herrmann@gmail.com \
    --cc=ebiederm@xmission.com \
    --cc=eparis@redhat.com \
    --cc=fabf@skynet.be \
    --cc=hch@infradead.org \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=koct9i@gmail.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mattst88@gmail.com \
    --cc=mcgrof@suse.com \
    --cc=mhocko@suse.cz \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pefoley2@pefoley.com \
    --cc=pieter@boesman.nl \
    --cc=tj@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zhenglong.cai@cs2c.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.