From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH for-xen-4.5] Add configure
	--with-extra-cflags-*
Date: Tue, 21 Oct 2014 11:07:43 +0200
Message-ID: <20141021090743.GB17073@aepfle.de>
References: <1412847832-24047-1-git-send-email-olaf@aepfle.de>
	<1413808836.4087.15.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1413808836.4087.15.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, Oct 20, Ian Campbell wrote:

> On Thu, 2014-10-09 at 11:43 +0200, Olaf Hering wrote:
> 
> Please do not use the "for-xen-4.5" without making some sort of argument
> as to why it should be acceptable for 4.5, usually after the ---
> separator.
> 
> To me this looks like a feature, but in any case neither Konrad nor I
> should be expected to make the argument for you.

The point is that the build system should not take "random" environment
variables. Instead such things should be passed in via configure. Now
that configure does already most of the settings it should do also this.

Olaf