From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH for 4.5 v2] vmx, apicv: fix save/restore issue with apicv Date: Tue, 21 Oct 2014 12:36:49 +0200 Message-ID: <20141021103649.GA31072@aepfle.de> References: <1413869566-23391-1-git-send-email-yang.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1413869566-23391-1-git-send-email-yang.z.zhang@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Yang Zhang Cc: Andrew.Cooper3@citrix.com, kevin.tian@intel.com, malcolm.crossley@citrix.com, JBeulich@suse.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, Oct 21, Yang Zhang wrote: > From: Yang Zhang > > This patch fixes two issues: > > 1. Interrupts on PIR are lost during save/restore. Syncing the PIR > into IRR during save will fix it. > > 2. EOI exit bitmap doesn't set up correctly after restore. Here we > will construct the eoi exit bitmap via (IRR | ISR). Though it may cause > unnecessary eoi exit of the interrupts that pending in IRR or ISR during > save/restore, each pending interrupt only causes one vmexit. The > subsequent interrupts will adjust the eoi exit bitmap correctly. So > the performance hurt can be ignored. > > Signed-off-by: Yang Zhang > Signed-off-by: Olaf Hering > --- > Hi Olaf and Malcolm, please help to retest this version. Yes, this works as well. Thanks! Olaf