From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Alexandre FOURNIER" <alexandre.fournier@wisp-e.com>,
"Ezequiel Garcia" <ezequiel.garcia@free-electrons.com>,
"Marcin Wojtas" <mw@semihalf.com>,
"Gregory Clément" <gregory.clement@free-electrons.com>
Subject: Re: RCU stall in af_unix.c, should use spin_lock_irqsave?
Date: Tue, 21 Oct 2014 12:13:04 +0200 [thread overview]
Message-ID: <20141021121304.076d5acd@free-electrons.com> (raw)
In-Reply-To: <1413886132.32553.14.camel@localhost>
Dear Hannes Frederic Sowa,
On Tue, 21 Oct 2014 12:08:52 +0200, Hannes Frederic Sowa wrote:
> On Di, 2014-10-21 at 10:03 +0200, Thomas Petazzoni wrote:
> > So, the question is: is this patch the correct solution (but then other
> > usage of spin_lock in af_unix.c might also need fixing) ? Or is the
> > network driver at fault?
>
> It feels like a false positive. Do you see one core spinning tightly on
> a lock? Does the system get unusable?
Interrupts are still enabled (for example, sysrq are still working),
but scheduling no longer takes place (all processes are blocked).
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-21 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 8:03 RCU stall in af_unix.c, should use spin_lock_irqsave? Thomas Petazzoni
2014-10-21 10:04 ` Eric Dumazet
2014-10-21 10:10 ` Thomas Petazzoni
2014-10-21 10:28 ` Eric Dumazet
2014-10-21 11:58 ` Thomas Petazzoni
2014-10-21 10:08 ` Hannes Frederic Sowa
2014-10-21 10:13 ` Thomas Petazzoni [this message]
[not found] <6E9AD71A-9E19-437F-A94B-D8B267F533EA@opengear.com>
2015-06-16 9:19 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021121304.076d5acd@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=alexandre.fournier@wisp-e.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=hannes@stressinduktion.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.