From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [RESUBMIT PATCH v4 1/8] mfd: Add support for Skyworks SKY81452 driver Date: Tue, 21 Oct 2014 13:30:01 +0100 Message-ID: <20141021123001.GA4939@x1> References: <1412657745-7812-1-git-send-email-jack.yoo@skyworksinc.com> <1413179262-27636-1-git-send-email-jack.yoo@skyworksinc.com> <1413179262-27636-2-git-send-email-jack.yoo@skyworksinc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1413179262-27636-2-git-send-email-jack.yoo-tjhQNA90jdKqndwCJWfcng@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Gyungoh Yoo Cc: sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jack.yoo-tjhQNA90jdKqndwCJWfcng@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org, shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org, treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, florian.vaussard-p8DiymsW2f8@public.gmane.org, trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, andrew-g2DYL2Zd6BY@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, 13 Oct 2014, Gyungoh Yoo wrote: > Signed-off-by: Gyungoh Yoo > --- > Changes v4: > Removed MODULE_VERSION() > Modified license to GPLv2 >=20 > Changes v3: > Fixed the backlight name from 'sky81452-bl' to 'sky81452-backlight' > Assigned mfd_cell.of_compatible for binding device node > Modified error messages >=20 > Changes v2: > Renamed CONFIG_SKY81452 to CONFIG_MFD_SKY81452 > Changed the dependency from I2C=3Dy to I2C, for CONFIG_MFD_SKY81452 > Added message for exception or errors >=20 > drivers/mfd/Kconfig | 12 +++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/sky81452.c | 110 +++++++++++++++++++++++++++++++++= ++++++++++ > include/linux/mfd/sky81452.h | 32 +++++++++++++ > 4 files changed, 155 insertions(+) > create mode 100644 drivers/mfd/sky81452.c > create mode 100644 include/linux/mfd/sky81452.h [...] > +++ b/include/linux/mfd/sky81452.h > @@ -0,0 +1,32 @@ > +/* > + * sky81452.h SKY81452 MFD driver > + * > + * Copyright 2014 Skyworks Solutions Inc. > + * Author : Gyungoh Yoo > + * > + * This program is free software; you can redistribute it and/or mod= ify it > + * under the terms of the GNU General Public License as published by= the > + * Free Software Foundation; either version 2, or (at your option) a= ny > + * later version. > + * > + * This program is distributed in the hope that it will be useful, b= ut > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License= along > + * with this program; if not, see . > + */ > + > +#ifndef _SKY81452_H > +#define _SKY81452_H > + > +#include Shouldn't this live in linux/platform_data? > +#include > + > +struct sky81452_platform_data { > + struct sky81452_bl_platform_data *bl_pdata; > + struct regulator_init_data *regulator_init_data; > +}; > + > +#endif --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755566AbaJUMaM (ORCPT ); Tue, 21 Oct 2014 08:30:12 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:34979 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755346AbaJUMaK (ORCPT ); Tue, 21 Oct 2014 08:30:10 -0400 Date: Tue, 21 Oct 2014 13:30:01 +0100 From: Lee Jones To: Gyungoh Yoo Cc: sameo@linux.intel.com, jg1.han@samsung.com, cooloney@gmail.com, broonie@kernel.org, lgirdwood@gmail.com, jack.yoo@skyworksinc.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, grant.likely@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, pawel.moll@arm.com, heiko@sntech.de, jason@lakedaemon.net, shawn.guo@freescale.com, treding@nvidia.com, florian.vaussard@epfl.ch, trivial@kernel.org, linux@roeck-us.net, andrew@lunn.ch, jic23@kernel.org Subject: Re: [RESUBMIT PATCH v4 1/8] mfd: Add support for Skyworks SKY81452 driver Message-ID: <20141021123001.GA4939@x1> References: <1412657745-7812-1-git-send-email-jack.yoo@skyworksinc.com> <1413179262-27636-1-git-send-email-jack.yoo@skyworksinc.com> <1413179262-27636-2-git-send-email-jack.yoo@skyworksinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1413179262-27636-2-git-send-email-jack.yoo@skyworksinc.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Oct 2014, Gyungoh Yoo wrote: > Signed-off-by: Gyungoh Yoo > --- > Changes v4: > Removed MODULE_VERSION() > Modified license to GPLv2 > > Changes v3: > Fixed the backlight name from 'sky81452-bl' to 'sky81452-backlight' > Assigned mfd_cell.of_compatible for binding device node > Modified error messages > > Changes v2: > Renamed CONFIG_SKY81452 to CONFIG_MFD_SKY81452 > Changed the dependency from I2C=y to I2C, for CONFIG_MFD_SKY81452 > Added message for exception or errors > > drivers/mfd/Kconfig | 12 +++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/sky81452.c | 110 +++++++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/sky81452.h | 32 +++++++++++++ > 4 files changed, 155 insertions(+) > create mode 100644 drivers/mfd/sky81452.c > create mode 100644 include/linux/mfd/sky81452.h [...] > +++ b/include/linux/mfd/sky81452.h > @@ -0,0 +1,32 @@ > +/* > + * sky81452.h SKY81452 MFD driver > + * > + * Copyright 2014 Skyworks Solutions Inc. > + * Author : Gyungoh Yoo > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2, or (at your option) any > + * later version. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, see . > + */ > + > +#ifndef _SKY81452_H > +#define _SKY81452_H > + > +#include Shouldn't this live in linux/platform_data? > +#include > + > +struct sky81452_platform_data { > + struct sky81452_bl_platform_data *bl_pdata; > + struct regulator_init_data *regulator_init_data; > +}; > + > +#endif -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog