From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Ashley Lai <ashley@ashleylai.com>,
Marcel Selhorst <tpmdd@selhorst.net>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH] tpm: fix multiple race conditions in tpm_ppi.c
Date: Tue, 21 Oct 2014 10:55:51 -0600 [thread overview]
Message-ID: <20141021165551.GA28382@obsidianresearch.com> (raw)
In-Reply-To: <1413879761-25392-1-git-send-email-jarkko.sakkinen@linux.intel.com>
On Tue, Oct 21, 2014 at 11:22:41AM +0300, Jarkko Sakkinen wrote:
> * Traversal of the ACPI device tree was not done right. It should lookup
> PPI only under the ACPI device that it is associated. Otherwise, it could
> match to a wrong PPI interface if there are two TPM devices in the device
> tree.
> * Removed global ACPI handle and version string from tpm_ppi.c as this
> is racy. Instead they should be associated with the chip.
> * Moved code just a tiny bit towards two-phase allocation to implement
> fix for the PPI race conditions.
> * Added missing copyright platter in tpm_ppi.c.
The PPI parts of this look fine to me, and are a really nice cleanup,
thanks!
Personally, I'd sequence this commit right after your 'tpm: two-phase
chip management functions' commit because it makes it much saner (no
half step toward the new functions). I assume this is a theoretical
problem? Or do you have a two TPM system?
Jason
next prev parent reply other threads:[~2014-10-21 16:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 8:22 [PATCH] tpm: fix multiple race conditions in tpm_ppi.c Jarkko Sakkinen
2014-10-21 16:55 ` Jason Gunthorpe [this message]
2014-10-21 20:42 ` [tpmdd-devel] " Jarkko Sakkinen
2014-10-21 21:02 ` Jason Gunthorpe
2014-10-22 10:05 ` Jarkko Sakkinen
2014-10-22 13:00 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021165551.GA28382@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=ashley@ashleylai.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.