From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-out.m-online.net ([212.18.0.9]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xghrz-0002Iq-Lu for linux-mtd@lists.infradead.org; Tue, 21 Oct 2014 22:25:36 +0000 From: Marek Vasut To: =?utf-8?q?Rafa=C5=82_Mi=C5=82ecki?= Subject: Re: [PATCH] mtd: spi-nor: Add support for SST spi flash Date: Wed, 22 Oct 2014 00:08:51 +0200 References: <29606567142da0d52c462ef0aebacc2b91fe2508.1413891469.git.michal.simek@xilinx.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <201410220008.51848.marex@denx.de> Cc: monstr@monstr.eu, Geert Uytterhoeven , Michal Simek , Linux Kernel Mailing List , Huang Shijie , "linux-mtd@lists.infradead.org" , Peter Crosthwaite , Harini Katakam , Brian Norris , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tuesday, October 21, 2014 at 06:43:50 PM, Rafa=C5=82 Mi=C5=82ecki wrote: > On 21 October 2014 13:37, Michal Simek wrote: > > From: Harini Katakam > >=20 > > Add sst25wf080 to the spi-nor device id table. >=20 > I guess commit message could include some details. We already support > plenty of SST flashes without this patch, don't we? This change is so trivial that saying "we're adding this new flash chip ID = to=20 the ID table", which is what Michal did, is completely sufficient in my opi= nion. Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933773AbaJUWZP (ORCPT ); Tue, 21 Oct 2014 18:25:15 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:35128 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbaJUWZN convert rfc822-to-8bit (ORCPT ); Tue, 21 Oct 2014 18:25:13 -0400 X-Auth-Info: nHgjfcgxMmPazTOPPwsaH7j1M/WFfQqQaBPkvmNkP5g= From: Marek Vasut To: =?utf-8?q?Rafa=C5=82_Mi=C5=82ecki?= Subject: Re: [PATCH] mtd: spi-nor: Add support for SST spi flash Date: Wed, 22 Oct 2014 00:08:51 +0200 User-Agent: KMail/1.13.7 (Linux/3.13-trunk-amd64; KDE/4.13.1; x86_64; ; ) Cc: Michal Simek , Linux Kernel Mailing List , monstr@monstr.eu, Harini Katakam , David Woodhouse , Brian Norris , Huang Shijie , Peter Crosthwaite , Geert Uytterhoeven , "linux-mtd@lists.infradead.org" References: <29606567142da0d52c462ef0aebacc2b91fe2508.1413891469.git.michal.simek@xilinx.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Message-Id: <201410220008.51848.marex@denx.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, October 21, 2014 at 06:43:50 PM, Rafał Miłecki wrote: > On 21 October 2014 13:37, Michal Simek wrote: > > From: Harini Katakam > > > > Add sst25wf080 to the spi-nor device id table. > > I guess commit message could include some details. We already support > plenty of SST flashes without this patch, don't we? This change is so trivial that saying "we're adding this new flash chip ID to the ID table", which is what Michal did, is completely sufficient in my opinion. Best regards, Marek Vasut