From: Eduardo Otubo <eduardo.otubo@profitbricks.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Philipp Gesang <philipp.gesang@intra2net.com>
Subject: Re: [Qemu-devel] [PULL 00/01] Adding new syscalls to seccomp whitelist
Date: Wed, 22 Oct 2014 10:04:48 +0200 [thread overview]
Message-ID: <20141022080447.GA23653@vader> (raw)
In-Reply-To: <CAFEAcA-Ef8_QExyOiOqKwnVYecsdA_jXwP9ffn6A69rQnJzFNQ@mail.gmail.com>
On Fri, Sep 19, 2014 at 08:11:14AM -0700, Peter Maydell wrote:
> On 19 September 2014 07:38, Eduardo Otubo
> <eduardo.otubo@profitbricks.com> wrote:
> > On Fri, Sep 19, 2014 at 4:15 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> >> ...how about fixing your compile errors on non-x86 platforms
> >> before adding more stuff here?
> >
> > Hm, indeed. I should have double checked that. Thanks for pointing that out.
> >
> > Philipp, can you fix this, please?
>
> You have compile problems in current master as well. Your macros
> probably need to guard themselves on whether the syscall they're
> adding to the list actually exists on the host.
> (See bug https://bugs.launchpad.net/qemu/+bug/1363641 -- select
> doesn't exist as a syscall on all archs.)
The fix for that problem is upstream at libseccomp. The maintainer has
no plans yet to make a new release, though. Once he does a release nad
fix this issue, I'll go and resubmit this pull request.
Thanks,
--
Eduardo Otubo
ProfitBricks GmbH
next prev parent reply other threads:[~2014-10-22 8:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 13:22 [Qemu-devel] [PULL 00/01] Adding new syscalls to seccomp whitelist Eduardo Otubo
2014-09-19 13:22 ` [Qemu-devel] [PULL 01/01] seccomp: whitelist syscalls fallocate(), fadvise64(), inotify_init1() and inotify_add_watch() Eduardo Otubo
2014-09-19 14:15 ` [Qemu-devel] [PULL 00/01] Adding new syscalls to seccomp whitelist Peter Maydell
2014-09-19 14:38 ` Eduardo Otubo
2014-09-19 15:11 ` Peter Maydell
2014-10-22 8:04 ` Eduardo Otubo [this message]
2014-10-22 10:02 ` Peter Maydell
2014-11-05 13:19 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022080447.GA23653@vader \
--to=eduardo.otubo@profitbricks.com \
--cc=peter.maydell@linaro.org \
--cc=philipp.gesang@intra2net.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.