All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Chuck Ebbert <cebbert.lkml@gmail.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/crtc: Fix two typos
Date: Wed, 22 Oct 2014 10:38:29 +0200	[thread overview]
Message-ID: <20141022083829.GL26941@phenom.ffwll.local> (raw)
In-Reply-To: <20141021140141.GK4284@intel.com>

On Tue, Oct 21, 2014 at 05:01:41PM +0300, Ville Syrjälä wrote:
> On Wed, Oct 08, 2014 at 11:37:20AM -0500, Chuck Ebbert wrote:
> > Fix:
> > 
> >   ioclt -> ioctl in comment
> >   wrong variable name in debug message
> > 
> > Signed-off-by: Chuck Ebbert <cebbert.lkml@gmail.com>
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> > ---
> > 
> > --- drivers/gpu/drm/drm_crtc.c.orig	2014-10-08 11:29:50.948406186 -0500
> > +++ drivers/gpu/drm/drm_crtc.c	2014-10-08 11:30:55.781479300 -0500

This diff was manually generated and failed to apply using the usual
tooling. Please generate patches using git format-patch and send it
using git send-email, they get all the details right.

I've fixed it up while applying.
-Daniel

> > @@ -2913,7 +2913,7 @@ EXPORT_SYMBOL(drm_mode_legacy_fb_format)
> >   * @file_priv: drm file for the ioctl call
> >   *
> >   * Add a new FB to the specified CRTC, given a user request. This is the
> > - * original addfb ioclt which only supported RGB formats.
> > + * original addfb ioctl which only supported RGB formats.
> >   *
> >   * Called by the user via ioctl.
> >   *
> > @@ -3033,7 +3033,7 @@ static int framebuffer_check(const struc
> >  	num_planes = drm_format_num_planes(r->pixel_format);
> >  
> >  	if (r->width == 0 || r->width % hsub) {
> > -		DRM_DEBUG_KMS("bad framebuffer width %u\n", r->height);
> > +		DRM_DEBUG_KMS("bad framebuffer width %u\n", r->width);
> >  		return -EINVAL;
> >  	}
> >  
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> -- 
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

      reply	other threads:[~2014-10-22  8:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08 16:37 [PATCH] drm/crtc: Fix two typos Chuck Ebbert
2014-10-21 14:01 ` Ville Syrjälä
2014-10-22  8:38   ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141022083829.GL26941@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=cebbert.lkml@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.