All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: akpm@linux-foundation.org
Cc: a.zummo@towertech.it, ijc+devicetree@hellion.org.uk,
	jason@lakedameon.net, linux@roeck-us.net,
	matti.vaittinen@nsn.com, robh+dt@kernel.org, mike@bfo.com,
	kernel list <linux-kernel@vger.kernel.org>,
	rtc-linux@googlegroups.com
Subject: [patch] rtc: bq3000: fix register value
Date: Wed, 22 Oct 2014 13:35:20 +0200	[thread overview]
Message-ID: <20141022113520.GA32184@amd> (raw)
In-Reply-To: <543d6974.2KPlDgEZUrUl6vsa%akpm@linux-foundation.org>


Fix register value in bq32000 trickle charging. 

Mike reported that I'm using wrong value in one trickle-charging case,
and after checking docs, I must admit he's right.
    
Signed-off-by: Pavel Machek <pavel@denx.de>
Reported-by: Mike Bremford <mike@bfo.com>

diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c
index c02e246..54e9f7a 100644
--- a/drivers/rtc/rtc-bq32k.c
+++ b/drivers/rtc/rtc-bq32k.c
@@ -160,7 +160,7 @@ static int trickle_charger_of_init(struct device *dev, struct device_node *node)
 			dev_err(dev, "bq32k: diode and resistor mismatch\n");
 			return -EINVAL;
 		}
-		reg = 0x25;
+		reg = 0x45;
 		break;
 
 	default:

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

      reply	other threads:[~2014-10-22 11:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-14 18:20 [merged] rtc-bq32000-add-trickle-charger-device-tree-binding.patch removed from -mm tree akpm
2014-10-22 11:35 ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141022113520.GA32184@amd \
    --to=pavel@ucw.cz \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jason@lakedameon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=matti.vaittinen@nsn.com \
    --cc=mike@bfo.com \
    --cc=robh+dt@kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.