Re: [PATCH 3/3] systemd: xendomains now depends on xen-init-dom0

[Wei Liu <wei.liu2@citrix.com>]

On Wed, Oct 22, 2014 at 12:57:24PM +0100, Anthony PERARD wrote:
> On Tue, Oct 21, 2014 at 10:56:12AM +0100, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  tools/hotplug/Linux/systemd/xendomains.service.in |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/hotplug/Linux/systemd/xendomains.service.in b/tools/hotplug/Linux/systemd/xendomains.service.in
> > index f88c336..8577317 100644
> > --- a/tools/hotplug/Linux/systemd/xendomains.service.in
> > +++ b/tools/hotplug/Linux/systemd/xendomains.service.in
> > @@ -1,7 +1,7 @@
> >  [Unit]
> >  Description=Xendomains - start and stop guests on boot and shutdown
> >  Requires=xenstored.socket
> > -After=xenstored.service xenconsoled.service
> > +After=xenstored.service xenconsoled.service xen-init-dom0.service
> >  ConditionVirtualization=xen
> 
> Having a service listed in After does not mean a service depends on the
> other. It just mean: run xendomains.service after xen-init-dom0.service,
> but xen-init-dom0.service might not run at all..
> 
> If xen-init-dom0.service needs to be run before xendomains.service, you
> also need to add it to the Requires list.
> 

Then I must have misread the manual

"After= ensures that the configured unit is started after the listed
unit finished starting up"

Looks like "finished starting up" doesn't guarantee it exits with
success?

> So the patch should probably look like this:
> -Requires=xenstored.socket
> -After=xenstored.service xenconsoled.service
> +Requires=xenstored.socket xen-init-dom0.service
> +After=xenstored.service xenconsoled.service xen-init-dom0.service
> 
> (This also means, if xen-init-dom0 fail, xendomains will not be started
> at all.)
> 

Anyway, this looks sensible and it's what I expect. I will add in that
line.

Wei.



> -- 
> Anthony PERARD