From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 22 Oct 2014 09:53:48 -0400 Subject: [U-Boot] [PATCH 1/4] Add deep sleep framework support for Freescale QorIQ platforms In-Reply-To: <1411894788-41758-2-git-send-email-Yuantian.Tang@freescale.com> References: <1411894788-41758-1-git-send-email-Yuantian.Tang@freescale.com> <1411894788-41758-2-git-send-email-Yuantian.Tang@freescale.com> Message-ID: <20141022135348.GD25506@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, Sep 28, 2014 at 04:59:45PM +0800, Yuantian.Tang at freescale.com wrote: > From: Tang Yuantian > > When Freescale QorIQ SoCs wake up from deep sleep, control is > passed to the primary core that starts executing uboot. After > re-initialized some IP blocks, like DDRC, kernel will take > responsibility to continue to restore environment it leaves before. > > This patch adds the deep sleep framework support for all Freescale > QorIQ platforms that use generic_board configuation. > > Signed-off-by: Tang Yuantian > --- > common/board_f.c | 10 +++++++++ > drivers/ddr/fsl/arm_ddr_gen3.c | 48 +++++++++++++++++++++++++++++++++++++----- > include/fsl_ddr_sdram.h | 2 ++ > include/fsl_sleep.h | 32 ++++++++++++++++++++++++++++ > 4 files changed, 87 insertions(+), 5 deletions(-) > create mode 100644 include/fsl_sleep.h > > diff --git a/common/board_f.c b/common/board_f.c > index e6aa298..b736d29 100644 > --- a/common/board_f.c > +++ b/common/board_f.c > @@ -56,6 +56,9 @@ > #endif > #include > #include > +#ifdef CONFIG_FSL_DEEP_SLEEP > +#include > +#endif > > /* > * Pointer to initial global data area > @@ -921,6 +924,9 @@ static init_fnc_t init_sequence_f[] = { > #if defined(CONFIG_MIPS) || defined(CONFIG_PPC) > init_func_ram, > #endif > +#ifdef CONFIG_FSL_DEEP_SLEEP > + fsl_dp_resume, > +#endif Is there not an existing hook you can use here instead? Is misc_init_f too early? If we're going to add a new hook in here, it needs to be somewhat generically named, with the requirements of the system spelled out. Some TI parts have a (setting aside marketing-speak) similar function and I believe the U-Boot patches for that use an existing hook to notice what happened and do what's needed. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: