Re: [PATCH 0/3] iommu: replace IOMMU_EXEC with IOMMU_EXEC and update ARM SMMU driver

["jroedel-l3A5Bk7waGM@public.gmane.org" <jroedel-l3A5Bk7waGM@public.gmane.org>]

On Mon, Oct 20, 2014 at 07:42:01PM +0100, Will Deacon wrote:
> On Mon, Oct 20, 2014 at 04:39:15PM +0100, Will Deacon wrote:
> > On Mon, Oct 13, 2014 at 02:06:15PM +0100, Antonios Motakis wrote:
> > > This patch series applies to Joerg Roedel's iommu/next branch, commit 09b5269a.
> > > It replaces the IOMMU_EXEC flag used by the ARM SMMU driver to IOMMU_NOEXEC.
> > > This is more enforceable, since the lack of the flag on hardware that doesn't
> > > support it implies that the target memory will be executable.
> > 
> > Looks good to me; I'll take this via the arm-smmu tree and send it to Joerg
> > along with anything else that gets queued for 3.19.
> 
> The 0-day builder spotted a new warning from this series:
> 
>    drivers/iommu/amd_iommu.c: In function 'amd_iommu_capable':
> >> drivers/iommu/amd_iommu.c:3409:2: warning: enumeration value 'IOMMU_CAP_NOEXEC' not handled in switch [-Wswitch]
>      switch (cap) {
>      ^
> 
> I fixed it with the patch below, but I'd appreciate you and Joerg taking
> a look too.
> 
> Cheers,
> 
> Will
> 
> --->8
> 
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index 505a9adac2d5..3d78a8fb5a6a 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -3411,6 +3411,8 @@ static bool amd_iommu_capable(enum iommu_cap cap)
>                 return true;
>         case IOMMU_CAP_INTR_REMAP:
>                 return (irq_remapping_enabled == 1);
> +       case IOMMU_CAP_NOEXEC:
> +               return false;
>         }

Looks good to me.