All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"Kamble, Sagar A" <sagar.a.kamble@intel.com>
Subject: Re: [PATCH] drm/i915: Add rotation support for cursor plane
Date: Thu, 23 Oct 2014 10:49:16 +0200	[thread overview]
Message-ID: <20141023084916.GC26941@phenom.ffwll.local> (raw)
In-Reply-To: <20141023002924.GV22350@intel.com>

On Wed, Oct 22, 2014 at 05:29:24PM -0700, Matt Roper wrote:
> On Tue, Oct 07, 2014 at 08:43:46AM +0000, Jindal, Sonika wrote:
> > Hi,
> > 
> > Did anybody get a chance to look at this patch?
> > 
> > Thanks,
> > Sonika
> 
> Looks like we waited a bit too long and the codebase has evolved, so I
> needed to make some tweaks to your patches to get them to apply cleanly
> on the latest di-nightly.  However the overall changes here look good to
> me, and we don't seem to be missing any details from the bspec, so
> 
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> 
> After tweaking your patches to apply against the latest di-nightly, your
> i-g-t test runs properly for me on IVB, as well as another simple test I
> wrote myself, so you can also put
> 
> Tested-by: Matt Roper <matthew.d.roper@intel.com>
> 
> Let me know if you want the rebased copies of the patches I used for
> testing.

Lazy maintainer here. That would be awesome ;-) Since you've frobbed the
patches a bit pls also put your sob onto them.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2014-10-23  8:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-15  7:35 [PATCH 1/2] drm/i915: Update plane parameters for cursor plane sonika.jindal
2014-09-15  7:35 ` [PATCH 2/2] drm/i915: Add rotation support " sonika.jindal
2014-09-15  7:43   ` [PATCH] " sonika.jindal
2014-10-07  8:43     ` Jindal, Sonika
2014-10-23  0:29       ` Matt Roper
2014-10-23  8:49         ` Daniel Vetter [this message]
2014-10-23 14:41           ` [PATCH 1/2] drm/i915: Update plane parameters for cursor plane (v2) Matt Roper
2014-10-23 14:41             ` [PATCH 2/2] drm/i915: Add rotation support for cursor plane (v5) Matt Roper
2014-10-23 15:36               ` Daniel Vetter
2014-10-23 15:48           ` [PATCH i-g-t] kms_rotation_crc: Add test for cursor rotation (v2) Matt Roper
2014-09-15  7:55 ` [PATCH 1/2] drm/i915: Update plane parameters for cursor plane Jani Nikula
2014-09-15 10:43   ` Jindal, Sonika

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141023084916.GC26941@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    --cc=sagar.a.kamble@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.