From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dolev Raviv <draviv@codeaurora.org>
Cc: subhashj@codeaurora.org, linux-scsi@vger.kernel.org
Subject: Re: ufs: add UFS power management support
Date: Thu, 23 Oct 2014 13:06:30 +0300 [thread overview]
Message-ID: <20141023100630.GI26918@mwanda> (raw)
In-Reply-To: <009c01cfee93$00a96b60$01fc4220$@codeaurora.org>
On Thu, Oct 23, 2014 at 10:28:52AM +0300, Dolev Raviv wrote:
> Hi Dan,
> This seem like a false alarm, please let me know if it requires a fix.
>
It may not indicate a bug, but it is correct in that the code could be
re-written:
Old:
else if ((req_link_state == UIC_LINK_OFF_STATE) &&
(!check_for_bkops || (check_for_bkops &&
!hba->auto_bkops_enabled))) {
Proposed:
else if ((req_link_state == UIC_LINK_OFF_STATE) &&
(!check_for_bkops || !hba->auto_bkops_enabled)) {
Those two are the same.
regards,
dan carpenter
prev parent reply other threads:[~2014-10-23 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 15:31 ufs: add UFS power management support Dan Carpenter
2014-10-23 7:28 ` Dolev Raviv
2014-10-23 10:06 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023100630.GI26918@mwanda \
--to=dan.carpenter@oracle.com \
--cc=draviv@codeaurora.org \
--cc=linux-scsi@vger.kernel.org \
--cc=subhashj@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.