All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Markos Chandras <markos.chandras@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: idle: Remove leftover __pastwait symbol and its references
Date: Thu, 23 Oct 2014 19:29:26 +0200	[thread overview]
Message-ID: <20141023172926.GD1673@linux-mips.org> (raw)
In-Reply-To: <1410872228-12116-1-git-send-email-markos.chandras@imgtec.com>

On Tue, Sep 16, 2014 at 01:57:08PM +0100, Markos Chandras wrote:

> The __pastwait symbol was only used by the address_is_in_r4k_wait_irqoff
> function but this is no longer used since the SMTC removal in commit
> b633648c5ad3 ('MIPS: MT: Remove SMTC support'). That symbol also led to
> build failures under certain random configuration due to the way the
> compiler compiled the r4k_wait_irqoff function. If that function was
> called multiple times, the __pastwait symbol was redefined breaking the
> build like this:

Applied.  If this problems show up again on older kernels that still have
SMTC we still can cook up a different fix.

> CHK     include/generated/compile.h
> CC      arch/mips/kernel/idle.o
> {standard input}: Assembler messages:
> {standard input}:527: Error: symbol `__pastwait' is already defined
> 
> Link: http://www.linux-mips.org/archives/linux-mips/2009-06/msg00282.html

When posting any kind of reference please always use the permanent links.

Applied,

  Ralf

      reply	other threads:[~2014-10-23 17:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16 12:57 [PATCH] MIPS: idle: Remove leftover __pastwait symbol and its references Markos Chandras
2014-09-16 12:57 ` Markos Chandras
2014-10-23 17:29 ` Ralf Baechle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141023172926.GD1673@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=linux-mips@linux-mips.org \
    --cc=markos.chandras@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.