From: Ralf Baechle <ralf@linux-mips.org>
To: Markos Chandras <markos.chandras@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 2/3] MIPS: sead3: Build the I2C related devices if CONFIG_I2C is enabled
Date: Thu, 23 Oct 2014 20:19:26 +0200 [thread overview]
Message-ID: <20141023181925.GA6719@linux-mips.org> (raw)
In-Reply-To: <1412847261-7930-3-git-send-email-markos.chandras@imgtec.com>
On Thu, Oct 09, 2014 at 10:34:20AM +0100, Markos Chandras wrote:
> There is no point building the drivers for the i2c related devices if
> CONFIG_I2C is not enabled.
>
> This also fixes a randconfig problem:
>
> arch/mips/mti-sead3/sead3-pic32-i2c-drv.c: In function 'i2c_platform_probe':
> arch/mips/mti-sead3/sead3-pic32-i2c-drv.c:345:2: error: implicit declaration of
> function 'i2c_add_numbered_adapter' [-Werror=implicit-function-declaration]
> ret = i2c_add_numbered_adapter(&priv->adap);
> ^
> arch/mips/mti-sead3/sead3-pic32-i2c-drv.c: In function
> 'i2c_platform_remove':
> arch/mips/mti-sead3/sead3-pic32-i2c-drv.c:361:2: error: implicit declaration
> of function 'i2c_del_adapter' [-Werror=implicit-function-declaration]
> i2c_del_adapter(&priv->adap);
The platform devices should always be registered.
And why on earth is there an I2C drivers in arch? That should rather
go to drivers/i2c/busses/.
Ralf
next prev parent reply other threads:[~2014-10-23 18:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 9:34 [PATCH 0/3] Malta/SEAD3 kernel image size patches for 3.18 Markos Chandras
2014-10-09 9:34 ` Markos Chandras
2014-10-09 9:34 ` [PATCH 1/3] MIPS: Malta: Do not build the malta-amon.c file if CMP is not enabled Markos Chandras
2014-10-09 9:34 ` Markos Chandras
2014-10-09 9:34 ` [PATCH 2/3] MIPS: sead3: Build the I2C related devices if CONFIG_I2C is enabled Markos Chandras
2014-10-09 9:34 ` Markos Chandras
2014-10-23 18:19 ` Ralf Baechle [this message]
2014-10-24 8:15 ` Ralf Baechle
2014-10-24 10:06 ` [PATCH] MIPS: SEAD3: Nuke unused sead3-pic32-i2c-drv Ralf Baechle
[not found] ` <20141023181925.GA6719-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
2014-10-24 12:26 ` [PATCH] MIPS/I2C: Move SEAD3 I2C driver to where it belongs Ralf Baechle
2014-10-24 12:26 ` Ralf Baechle
[not found] ` <20141024122656.GC12641-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
2014-11-13 8:24 ` Wolfram Sang
2014-11-13 8:24 ` Wolfram Sang
2014-10-09 9:34 ` [PATCH 3/3] MIPS: sead3: Only build the led driver if LEDS_CLASS is enabled Markos Chandras
2014-10-09 9:34 ` Markos Chandras
2014-10-23 23:54 ` Ralf Baechle
2014-10-23 22:41 ` [PATCH 1/3] MIPS: SEAD3: Fix LED device registration Ralf Baechle
2014-10-23 23:32 ` [PATCH 2/3] MIPS: SEAD3: Collect LED platform device registration in a single file Ralf Baechle
2014-10-23 23:50 ` [PATCH 3/3] LED/MIPS: Move SEAD3 LED driver to where it belongs Ralf Baechle
2014-10-24 23:19 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023181925.GA6719@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.