From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Wang Long <long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: jdl-CYoMK+44s/E@public.gmane.org,
sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
peifeiyue-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] dtc: test: make the test output more friendly
Date: Fri, 24 Oct 2014 12:14:30 +0200 [thread overview]
Message-ID: <20141024101430.GB4794@voom> (raw)
In-Reply-To: <1414120757-17288-1-git-send-email-long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]
On Fri, Oct 24, 2014 at 03:19:17AM +0000, Wang Long wrote:
> when run the command 'make check', the format of the output as the follow:
>
> ../fdtput label01.dts.fdtput.test.dtb -p /you/are/drunk/sir/winston slurp -ts twice: PASS
> ../fdtput label01.dts.fdtput.test.dtb -cp "Lorem ipsum dolor sit amet, cons"...<4119 bytes>PASS
> ../fdtput label01.dts.fdtput.test.dtb -cp /chosen: PASS
> ../fdtput label01.dts.fdtput.test.dtb -cp /chosen/son: PASS
>
> this patch make the format of the output more firendly to developer, as the follow:
>
> ../fdtput label01.dts.fdtput.test.dtb -p /you/are/drunk/sir/winston slurp -ts twice: [ PASS ]
> ../fdtput label01.dts.fdtput.test.dtb -cp "Lorem ipsum dolor sit amet, cons"...<4119 bytes> [ PASS ]
> ../fdtput label01.dts.fdtput.test.dtb -cp /chosen: [ PASS ]
> ../fdtput label01.dts.fdtput.test.dtb -cp /chosen/son: [ PASS ]
>
> The test result print ooutput at the right side of the terminal.
> The "PASS" word printed in green color and the "FAILED" word
> printed in red color, which are more friendly to
> developer.
Sorry, I'm not inclined to accept this in the current form.
This approach assumes a particular type of ansi compatible terminal
which I'd prefer not to do.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-10-24 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 3:19 [PATCH] dtc: test: make the test output more friendly Wang Long
[not found] ` <1414120757-17288-1-git-send-email-long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-10-24 10:14 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024101430.GB4794@voom \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jdl-CYoMK+44s/E@public.gmane.org \
--cc=long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=peifeiyue-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.