From: Andy Whitcroft <apw@canonical.com>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jani Nikula <jani.nikula@intel.com>,
Kees Cook <keescook@chromium.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: fix use via symlink, make missing spelling file non-fatal
Date: Fri, 24 Oct 2014 11:39:39 +0100 [thread overview]
Message-ID: <20141024103939.GD2910@bark> (raw)
In-Reply-To: <1414143110.15751.13.camel@perches.com>
On Fri, Oct 24, 2014 at 02:31:50AM -0700, Joe Perches wrote:
> On Fri, 2014-10-24 at 10:02 +0100, Andy Whitcroft wrote:
> > On Thu, Oct 23, 2014 at 10:29:11AM -0700, Joe Perches wrote:
> >
> > [...]
> > > my $P = $0;
> > > -$P =~ s@(.*)/@@g;
> > > -my $D = $1;
> > > +my $D = dirname(abs_path($P));
> >
> > That changes the value of $P, I don't know if that is intended:
> >
> > my $D = dirname(abs_path($0));
> >
> > or
> >
> > my $D = abs_path($1);
> >
> > perhaps to keep $P as it was.
>
> I did it to show the executable passed on the cmdline better.
>
> It changes --help and some warn/die messages.
>
> It's not particularly important either way.
If it was intended then great. Either way is fine with me.
Acked-by: Andy Whitcroft <apw@canonical.com>
-apw
prev parent reply other threads:[~2014-10-24 10:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 10:43 regression: checkpatch.pl fails when called via symlink Jani Nikula
2014-10-22 12:20 ` Joe Perches
2014-10-22 13:25 ` Jani Nikula
2014-10-22 17:13 ` Joe Perches
2014-10-23 17:16 ` Jani Nikula
2014-10-23 17:29 ` [PATCH] checkpatch: fix use via symlink, make missing spelling file non-fatal Joe Perches
2014-10-23 18:52 ` Kees Cook
2014-10-24 9:02 ` Andy Whitcroft
2014-10-24 9:31 ` Joe Perches
2014-10-24 10:39 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024103939.GD2910@bark \
--to=apw@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=jani.nikula@intel.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.