From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
netfilter-devel@vger.kernel.org, bsd@redhat.com,
stephen@networkplumber.org, netdev@vger.kernel.org,
eric.dumazet@gmail.com, davidn@davidnewall.com,
"David S. Miller" <davem@davemloft.net>
Subject: Re: bridge: Do not compile options in br_parse_ip_options
Date: Fri, 24 Oct 2014 14:28:06 +0200 [thread overview]
Message-ID: <20141024122806.GA4571@salvia> (raw)
In-Reply-To: <20141024104149.GA7401@breakpoint.cc>
On Fri, Oct 24, 2014 at 12:41:49PM +0200, Florian Westphal wrote:
> Herbert Xu <herbert@gondor.apana.org.au> wrote:
> > bridge: Do not compile options in br_parse_ip_options
> >
> > Commit 462fb2af9788a82a534f8184abfde31574e1cfa0
> >
> > bridge : Sanitize skb before it enters the IP stack
> >
> > broke when IP options are actually used because it mangles the
> > skb as if it entered the IP stack which is wrong because the
> > bridge is supposed to operate below the IP stack.
> >
> > Since nobody has actually requested for parsing of IP options
> > this patch fixes it by simply reverting to the previous approach
> > of ignoring all IP options, i.e., zeroing the IPCB.
> >
> > If and when somebody who uses IP options and actually needs them
> > to be parsed by the bridge complains then we can revisit this.
> >
> > Reported-by: David Newall <davidn@davidnewall.com>
> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> Tested-by: Florian Westphal <fw@strlen.de>
Applied, thanks a lot for testing Florian.
prev parent reply other threads:[~2014-10-24 12:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-04 1:04 [PATCH nf next 0/3] bridge: netfilter: fix handling of ipv4 packets w. options Florian Westphal
2014-10-04 1:04 ` [PATCH nf next 1/3] bridge: prepend inet_skb_param dummy to bridge cb Florian Westphal
2014-10-04 1:04 ` [PATCH nf next 2/3] netfilter: bridge: don't parse ip headers in fwd and output path Florian Westphal
2014-10-04 1:04 ` [PATCH nf-next 3/3] netfilter: bridge: don't mangle ipv4 header options Florian Westphal
2014-10-04 3:56 ` [PATCH nf next 0/3] bridge: netfilter: fix handling of ipv4 packets w. options Herbert Xu
2014-10-04 10:04 ` Florian Westphal
2014-10-04 13:55 ` Herbert Xu
2014-10-04 14:18 ` bridge: Do not compile options in br_parse_ip_options Herbert Xu
2014-10-04 18:06 ` Florian Westphal
2014-10-05 3:53 ` bridge: Respect call-iptables sysctls everywhere Herbert Xu
2014-10-05 4:00 ` bridge: Save frag_max_size between PRE_ROUTING and POST_ROUTING Herbert Xu
2014-10-07 19:13 ` David Miller
2014-10-05 9:13 ` bridge: Respect call-iptables sysctls everywhere Florian Westphal
2014-10-05 10:18 ` Herbert Xu
2014-10-06 4:53 ` bridge: Do not compile options in br_parse_ip_options David Miller
2014-10-24 10:41 ` Florian Westphal
2014-10-24 12:28 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024122806.GA4571@salvia \
--to=pablo@netfilter.org \
--cc=bsd@redhat.com \
--cc=davem@davemloft.net \
--cc=davidn@davidnewall.com \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.