Re: Request for comments for SND_SOC_IMX_WM8731

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 955 bytes --]

On Fri, Oct 24, 2014 at 10:20:29AM -0200, Fabio Estevam wrote:
> On Fri, Oct 24, 2014 at 2:42 AM, Jonathan Bennett <jbscience87@gmail.com> wrote:

> > + ssi_clk = devm_clk_get(&codec_dev->dev, "cko");
> > + if (IS_ERR(ssi_clk)) {
> > + pr_err("Could not get \"cko\" clock \n");
> > + return PTR_ERR(ssi_clk);
> 
> I am not sure that adding the clock handling here is the correct approach.
> 
> The dts you use looks like:
> 
>    codec: wm8731@1a {
>       compatible = "wlf,wm8731";
>       reg = <0x1a>;
>       clocks = <&clks 173>, <&clks 158>, <&clks 201>, <&clks 200>;
>       clock-names = "pll4", "imx-ssi.1", "cko", "cko2";

> ,which does not match the current bindings for the wm8731. The wm8731
> driver could be extended to handle the clocks if needed, instead of
> handling them via machine driver.

The WM8731 doesn't have anything like that number of clock inputs so
hanging them off the WM8731 seems very confused.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]