From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [OPW PATCH V4] tools: xl: refactor code to parse network device options Date: Fri, 24 Oct 2014 13:16:49 -0400 Message-ID: <20141024171649.GB12318@laptop.dumpdata.com> References: <1413927381-21549-1-git-send-email-alecsandra.sandulescu@gmail.com> <1413977758.19198.12.camel@citrix.com> <20141022202146.GB6020@laptop.dumpdata.com> <1414050974.20604.79.camel@citrix.com> <3C254340-3D3F-4744-81FA-D9E65450D9A4@oracle.com> <1414099258.20604.84.camel@citrix.com> <1414137663.3584.5.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XhiVb-0000qD-37 for xen-devel@lists.xenproject.org; Fri, 24 Oct 2014 17:18:39 +0000 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Alexandra Sandulescu Cc: Konrad Rzeszutek Wilk , Wei Liu , Ian Campbell , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Fri, Oct 24, 2014 at 11:58:28AM +0300, Alexandra Sandulescu wrote: > Hello, > > I have tested stuff by hand (I took the code and created some structures - > a bit of workaround let's say). Should I test it with OSSTest too? No need to run the OSSTest, that was more for my own curiosity. > What I understood from Wei is that he tested my patch. Maybe I got it wrong. > > Thank you all, > Alex > > On Fri, Oct 24, 2014 at 11:01 AM, Ian Campbell > wrote: > > > On Thu, 2014-10-23 at 19:08 -0400, Konrad Rzeszutek Wilk wrote: > > > > He said the code *path*, not the code, IOW I would read that as "would > > > > be tested", NOT "has been tested". > > > > > > > > > > Aye. In which case let's wait for Alexandra's response to the testing > > > that Wei asked for. > > > > Alexandra replied to me (privately) a couple of days ago confirming that > > she has tested both code paths. > > > > > On a related note - one can setup OSSTest on ones own network, fairly > > easy right? > > > > Right in "standalone mode". It's far easier than it once was and we've > > been squashing speedbumps as new people try it. > > > > You do need some infrastructure such as PXE and dhcp and at least two > > machines (controller + test host). I think it would be overkill for a > > change of this magnitude (if that's what you were driving at). > > > > I think > > > > http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;h=9a85549cb600fa5be91bcbae6605f78616db63da;hb=2aa4fe7a4b138e5e88387af66f4fe14039a1f7ea > > is the best starting point for osstest, including standalone mode operation. > > > > Ian. > > > >