From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 0/7] tools/systemd fixes Date: Fri, 24 Oct 2014 14:19:32 -0400 Message-ID: <20141024181932.GC16071@laptop.dumpdata.com> References: <1414160230-15131-1-git-send-email-olaf@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1414160230-15131-1-git-send-email-olaf@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering , ian.campbell@citrix.com Cc: M A Young , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, Oct 24, 2014 at 04:17:03PM +0200, Olaf Hering wrote: > This series combines all outstanding changes for systemd service files. > Right now the existing service files will work only with older systemd > version (208?) which incorrectly set "ConditionVirtualization=xen" to > true in a dom0. There is no support for detecting dom0 in systemd. The > proper way to detect a dom0 is to check for control_d in > /proc/xen/capabilities. > > The content of the patches is unchanged compared to what was sent out to > the list already. A few patches are acked by IanC. > > New in this series is an update of the dependencies between services. As > Anthony correctly pointed out its better to depend on xenstore.socket > instead of xenstored.service. > > The last patch is a small helper to visualize dependencies. It made it > easier for me to see whats going on, so its included here as well. > > Olaf Ian, If you are waiting for my comments, I am OK with all of those patches going in. And Wei has Acked them so that is super! Release-Acked-by: Konrad Rzeszutek Wilk > > Olaf Hering (4): > tools/hotplug: fix conditions in systemd service files for dom0 > tools/hotplug: systemd xenstored dependencies > tools/hotplug: every systemd service depends on proc-xen.mount > tools/hotplug: add helper script to visualize systemd dependencies > > Wei Liu (3): > tools/hotplug: fix clean target in systemd Makefile > tools/hotplug: add systemd xen-init-dom0 service > tools/hotplug: xendomains now depends on xen-init-dom0 > > tools/configure.ac | 1 + > tools/hotplug/Linux/systemd/Makefile | 2 ++ > tools/hotplug/Linux/systemd/proc-xen.mount.in | 3 ++- > .../Linux/systemd/show_service_dependencies.sh | 31 ++++++++++++++++++++++ > .../Linux/systemd/var-lib-xenstored.mount.in | 4 ++- > .../hotplug/Linux/systemd/xen-init-dom0.service.in | 14 ++++++++++ > .../systemd/xen-qemu-dom0-disk-backend.service.in | 6 ++--- > .../hotplug/Linux/systemd/xen-watchdog.service.in | 2 +- > tools/hotplug/Linux/systemd/xenconsoled.service.in | 6 ++--- > tools/hotplug/Linux/systemd/xendomains.service.in | 6 ++--- > tools/hotplug/Linux/systemd/xenstored.service.in | 4 +-- > tools/hotplug/Linux/systemd/xenstored.socket.in | 4 ++- > tools/hotplug/Linux/systemd/xenstored_ro.socket.in | 4 ++- > 13 files changed, 70 insertions(+), 17 deletions(-) > create mode 100644 tools/hotplug/Linux/systemd/show_service_dependencies.sh > create mode 100644 tools/hotplug/Linux/systemd/xen-init-dom0.service.in >