From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] regulator: stub out devm_regulator_get_exclusive Date: Fri, 24 Oct 2014 21:11:38 +0100 Message-ID: <20141024201138.GL3729@sirena.org.uk> References: <1414178111-19525-1-git-send-email-balbi@ti.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Z1OTrj3C7qypP14j" Return-path: Content-Disposition: inline In-Reply-To: <1414178111-19525-1-git-send-email-balbi@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Felipe Balbi Cc: lgirdwood@gmail.com, Linux Kernel Mailing List , airlied@linux.ie, robdclark@gmail.com, davidb@codeaurora.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --Z1OTrj3C7qypP14j Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 24, 2014 at 02:15:11PM -0500, Felipe Balbi wrote: > If we don't stup that call out, we will have > build failures for any drivers using that function > when .config happens to have CONFIG_REGULATOR=3Dn. >=20 > One such case below, found with randconfig >=20 > drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c: In function =E2=80=98mdp4_kms_in= it=E2=80=99: > drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c:384:2: error: implicit declaratio= n \ As previously and repeatedly reported the regulator usage in this driver appears extremely problematic, among these problems is that it almost certainly has no sensible reason to be using regulator_get_exclusive() or any variant of it. Sadly every time it's been raised with the video people they've completely ignored the mail so here we are. Right now not having the stub seems to only be affecting buggy users (which given the use cases for _exclusive() isn't *that* surprising) so I'm more inclined to leave this there in the hope that the users get fixed or we can at least get some sort of dialogue with the relevant maintainers. --Z1OTrj3C7qypP14j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUSrJ2AAoJECTWi3JdVIfQCwoH/2k9n54oF/0ncPcTBJFadIft xJsA1y5EfYGKlCTw8rGCnM+NdMlOlHaOsvCFNwSZ+iCHsHTuviBXeM+rjOyuJhL5 77Q88xTOwHvd2uUdRn6Z6gryRspLyPAg80LThFwyYfzKTppAHZCcpqZ2W4Lx4V3M MXGnUWGsGyUFZ9Ek4qNp9E2aW2bNilvwXbr03s7GSiJpDQ68kzOsn6KM6wPxR+fo Nu1Virv61n8UooGiypZfDEYjPxRJ1qEQ13iWJLENRff+rt62nWKmvFroVOzX+2iM ncWTSJhEFtrftgGsfDyML983mUXY1VhOf/TCF9AX1QnZaPv62iMBzrUqausXzac= =ryRz -----END PGP SIGNATURE----- --Z1OTrj3C7qypP14j--