All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
Date: Fri, 24 Oct 2014 14:42:06 -0700	[thread overview]
Message-ID: <20141024214206.GG19933@dtor-ws> (raw)
In-Reply-To: <20141020064605.GB25349@x1>

On Mon, Oct 20, 2014 at 07:46:05AM +0100, Lee Jones wrote:
> On Sat, 18 Oct 2014, Linus Walleij wrote:
> 
> > This adds the register offsets for pull up/down for the STMPE
> > 1601, 1801 and 24xx expanders. This is used to bias GPIO lines
> > and keypad lines.
> > 
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
> > patch series through the input tree, where the registers need to be
> > used to enable the keypad on the STMPE2401.
> > ---
> >  drivers/mfd/stmpe.c       | 4 ++++
> >  drivers/mfd/stmpe.h       | 3 +++
> >  include/linux/mfd/stmpe.h | 2 ++
> >  3 files changed, 9 insertions(+)
> 
> Does this need to go in with the other patches in the set?
> 
> I'm _guessing_ that, as you've sent them separately, they can be
> applied separately?
> 
> This needs to go in via MFD, but for my own reference:
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>

The new register definitions are needed for patch #3.  If you insist on
this going through MFD then please take the other 2 patches with my Ack
through MFD tree as well I do not think we need the whole song and dance
trying to synchronize 2 trees.

Thanks.

-- 
Dmitry

  reply	other threads:[~2014-10-24 21:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-18 12:56 [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE Linus Walleij
2014-10-20  6:46 ` Lee Jones
2014-10-20  6:46   ` Lee Jones
2014-10-24 21:42   ` Dmitry Torokhov [this message]
2014-11-03 12:25     ` Lee Jones
2014-11-03 12:25       ` Lee Jones
2014-12-04 18:10       ` Linus Walleij
2014-12-04 18:23         ` Dmitry Torokhov
2014-10-29  9:55   ` Linus Walleij
2014-10-29 19:31     ` Dmitry Torokhov
2014-11-03  9:27       ` Linus Walleij
2014-11-03 12:57         ` Lee Jones
2014-11-03 12:57           ` Lee Jones
2014-11-03 15:27           ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141024214206.GG19933@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.